<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-2022-jp"> </head> <body> if user select manual dpm mode，we will disabe autowattman. When switch to auto, we will restart the auto wattman on Polaris, Restore to default profile mode on other ASICS. Best Regards Rex <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Alex Deucher <alexdeucher@gmail.com> Sent: Thursday, February 8, 2018 11:02:21 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 10/10] drm/amd/pp: Enable auto automan feature on Polaris <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">On Thu, Feb 8, 2018 at 4:14 AM, Rex Zhu <Rex.Zhu@amd.com> wrote: > Change-Id: I69b24ce65ddb361a89e5ac9b197ae6df9b60a9e5 > Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> Would be good to give a brief description of what autowattman actually does in the patch description. Also, we may need to manually select a profile in some cases (e.g., VR). Would that be a problem with autowattman? Alex > --- > drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c > index f50b6cd..549e830 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c > @@ -1023,6 +1023,10 @@ int polaris_set_asic_special_caps(struct pp_hwmgr *hwmgr) > phm_cap_set(hwmgr->platform_descriptor.platformCaps, > PHM_PlatformCaps_TCPRamping); > } > + > + if (hwmgr->feature_mask & PP_AUTOWATTMAN_MASK) > + hwmgr->autowattman_enabled = true; /* currently only enabled on polaris */ > + > return 0; > } > > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </div> </div> </body> </html>