<div dir="ltr">One of my colleagues did discover a "Radeon HG 5450 PCI" from February<br>2010 which did, apparently, have a Cedar GPU and very definitely had a<br>(plain old) PCI connector.<br><br>But I take your point, and will just drop the PCI/PCIE check.<br><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 22, 2018 at 12:04 PM, Michel Dänzer <span dir="ltr"><<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 2018-02-22 10:57 PM, Ben Crocker wrote:<br>
> In radeon_device_init, set the need_dma32 flag for Cedar chips<br>
> (e.g. FirePro 2270). This fixes, or at least works around, a bug<br>
> on PowerPC exposed by last year's commits<br>
><br>
> 8e3f1b1d8255105f31556aacf8aeb6<wbr>071b00d469 (Russell Currey)<br>
><br>
> and<br>
><br>
> 253fd51e2f533552ae35a0c661705d<wbr>a6c4842c1b (Alistair Popple)<br>
><br>
> which enabled the 64-bit DMA iommu bypass.<br>
><br>
> This caused the device to freeze, in some cases unrecoverably, and is<br>
> the subject of several bug reports internal to Red Hat.<br>
><br>
> Signed-off-by: Ben Crocker <<a href="mailto:bcrocker@redhat.com">bcrocker@redhat.com</a>><br>
> ---<br>
> drivers/gpu/drm/radeon/radeon_<wbr>device.c | 5 +++++<br>
> 1 file changed, 5 insertions(+)<br>
><br>
> diff --git a/drivers/gpu/drm/radeon/<wbr>radeon_device.c b/drivers/gpu/drm/radeon/<wbr>radeon_device.c<br>
> index ffc10cadcf34..ba7435bcd208 100644<br>
> --- a/drivers/gpu/drm/radeon/<wbr>radeon_device.c<br>
> +++ b/drivers/gpu/drm/radeon/<wbr>radeon_device.c<br>
> @@ -1397,6 +1397,11 @@ int radeon_device_init(struct radeon_device *rdev,<br>
> if ((rdev->flags & RADEON_IS_PCI) &&<br>
> (rdev->family <= CHIP_RS740))<br>
> rdev->need_dma32 = true;<br>
> +#ifdef CONFIG_PPC64<br>
> + if ((rdev->flags & (RADEON_IS_PCI | RADEON_IS_PCIE)) &&<br>
<br>
</span>Cedar is (like all Radeons from the last decade) always PCIe, so this<br>
flags check is redundant FWIW.<br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
--<br>
Earthling Michel Dänzer | <a href="http://www.amd.com" rel="noreferrer" target="_blank">http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<br>
</font></span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/amd-gfx</a><br>
</div></div></blockquote></div><br></div>