<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Good. I will follow in new power profile implementation.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Best Regards</p> <p style="margin-top:0;margin-bottom:0">Rex</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Felix Kuehling <felix.kuehling@amd.com><br> <b>Sent:</b> Wednesday, February 28, 2018 5:01 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amd/powerplay: fix power over limit on Fiji</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com><br> <br> <br> On 2018-02-27 03:57 PM, Eric Huang wrote:<br> > power containment disabled only on Fiji and compute<br> > power profile. It violates PCIe spec and may cause power<br> > supply failed. Enabling it will fix the issue, even the<br> > fix will drop performance of some compute tests.<br> ><br> > Signed-off-by: Eric Huang <JinHuiEric.Huang@amd.com><br> > ---<br> > drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 7 -------<br> > 1 file changed, 7 deletions(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c<br> > index 535d786..731475b 100644<br> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c<br> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c<br> > @@ -4630,13 +4630,6 @@ static int smu7_set_power_profile_state(struct pp_hwmgr *hwmgr,<br> > int tmp_result, result = 0;<br> > uint32_t sclk_mask = 0, mclk_mask = 0;<br> > <br> > - if (hwmgr->chip_id == CHIP_FIJI) {<br> > - if (request->type == AMD_PP_GFX_PROFILE)<br> > - smu7_enable_power_containment(hwmgr);<br> > - else if (request->type == AMD_PP_COMPUTE_PROFILE)<br> > - smu7_disable_power_containment(hwmgr);<br> > - }<br> > -<br> > if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_AUTO)<br> > return -EINVAL;<br> > <br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk128753" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15197742129180.5457681949530573" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15197742129090.9090568988882439" role="presentation" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_15197742129120.835708299818144" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_15197742129130.4305282230250884"></div> <div id="LPTitle_15197742129130.9571507421970917" style="top: 0px; color: rgb(0, 120, 215); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15197742129150.6912265617837361" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15197742129150.5516366737486946" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15197742129170.6831435326445039" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of ...</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </div> </body> </html>