<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Rex,<br>
<br>
I think still initializing the PSP even when you don't need it for
firmware upload sounds like a good idea to me.<br>
<br>
But take that with a grain of salt since I really on don't know
that part of the hardware so well.<br>
<br>
Christian.<br>
<br>
Am 09.03.2018 um 06:10 schrieb Zhu, Rex:<br>
</div>
<blockquote type="cite"
cite="mid:CY4PR12MB1687F2F0D4288F02D750C755FBDE0@CY4PR12MB1687.namprd12.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;"
dir="ltr">
<p style="margin-top:0;margin-bottom:0">Hi Alex,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">How about keep the
firmware type checking in
<font size="2"><span style="font-size:11pt;">set_ip_blocks</span></font>.</p>
<p style="margin-top:0;margin-bottom:0">and remove the same
check code in psp module.</p>
<p style="margin-top:0;margin-bottom:0">also no need to change
load type if psp load firmware failed in psp module.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Please review the
attached patch.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Best Regards</p>
<p style="margin-top:0;margin-bottom:0">Rex<br>
</p>
<div style="color: rgb(0, 0, 0);">
<hr tabindex="-1" style="display:inline-block;width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b>
amd-gfx <a class="moz-txt-link-rfc2396E" href="mailto:amd-gfx-bounces@lists.freedesktop.org"><amd-gfx-bounces@lists.freedesktop.org></a> on
behalf of Alex Deucher <a class="moz-txt-link-rfc2396E" href="mailto:alexdeucher@gmail.com"><alexdeucher@gmail.com></a><br>
<b>Sent:</b> Friday, March 9, 2018 4:54 AM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Cc:</b> Deucher, Alexander<br>
<b>Subject:</b> [PATCH 2/2] drm/amdgpu/soc15: always load
the psp IP module</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span
style="font-size:11pt;">
<div class="PlainText">We already handle the firmware
loading type checks in the<br>
psp module directly, no need for an additional check.<br>
<br>
Signed-off-by: Alex Deucher
<a class="moz-txt-link-rfc2396E" href="mailto:alexander.deucher@amd.com"><alexander.deucher@amd.com></a><br>
---<br>
drivers/gpu/drm/amd/amdgpu/soc15.c | 3 +--<br>
1 file changed, 1 insertion(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
b/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
index 8dc8b72ed49b..ecf58a68cf66 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c<br>
@@ -531,8 +531,7 @@ int soc15_set_ip_blocks(struct
amdgpu_device *adev)<br>
amdgpu_device_ip_block_add(adev,
&vega10_common_ip_block);<br>
amdgpu_device_ip_block_add(adev,
&gmc_v9_0_ip_block);<br>
amdgpu_device_ip_block_add(adev,
&vega10_ih_ip_block);<br>
- if (amdgpu_fw_load_type == 2 ||
amdgpu_fw_load_type == -1)<br>
-
amdgpu_device_ip_block_add(adev,
&psp_v3_1_ip_block);<br>
+ amdgpu_device_ip_block_add(adev,
&psp_v3_1_ip_block);<br>
if (!amdgpu_sriov_vf(adev))<br>
amdgpu_device_ip_block_add(adev,
&amdgpu_pp_ip_block);<br>
if (adev->enable_virtual_display
|| amdgpu_sriov_vf(adev))<br>
-- <br>
2.13.6<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<a previewremoved="true" id="LPlnk123469"
href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx"
moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
<div style="margin-bottom: 20px; overflow: auto;
width: 100%; text-indent: 0px;"
id="LPBorder_GT_15205709349260.10638474698232214">
<table role="presentation" style="width: 90%;
background-color: rgb(255, 255, 255); position:
relative; overflow: auto; padding-top: 20px;
padding-bottom: 20px; margin-top: 20px;
border-top: 1px dotted rgb(200, 200, 200);
border-bottom: 1px dotted rgb(200, 200, 200);"
id="LPContainer_15205709349240.2808290117558123"
cellspacing="0">
<tbody>
<tr style="border-spacing: 0px;" valign="top">
<td colspan="2" style="vertical-align: top;
position: relative; padding: 0px; display:
table-cell;"
id="TextCell_15205709349240.5375816182761378">
<div style="top: 0px; color: rgb(0, 120,
215); font-weight: 400; font-size: 21px;
font-family:
"wf_segoe-ui_light","Segoe
UI Light","Segoe WP
Light","Segoe
UI","Segoe
WP",Tahoma,Arial,sans-serif;
line-height: 21px;"
id="LPTitle_15205709349250.744041292827629">
<a target="_blank"
href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx"
style="text-decoration: none;"
id="LPUrlAnchor_15205709349250.5260705269625694"
moz-do-not-send="true">amd-gfx Info Page
- freedesktop.org</a></div>
<div style="margin: 10px 0px 16px; color:
rgb(102, 102, 102); font-weight: 400;
font-family:
"wf_segoe-ui_normal","Segoe
UI","Segoe
WP",Tahoma,Arial,sans-serif;
font-size: 14px; line-height: 14px;"
id="LPMetadata_15205709349250.4352603789039715">
lists.freedesktop.org</div>
<div style="display: block; color: rgb(102,
102, 102); font-weight: 400; font-family:
"wf_segoe-ui_normal","Segoe
UI","Segoe
WP",Tahoma,Arial,sans-serif;
font-size: 14px; line-height: 20px;
max-height: 100px; overflow: hidden;"
id="LPDescription_15205709349260.4456905619796764">
Subscribing to amd-gfx: Subscribe to
amd-gfx by filling out the following form.
Use of all freedesktop.org lists is
subject to our Code of ...</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
</div>
</span></font></div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</body>
</html>