<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Apply it and thanks.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Best Regards</p>
<p style="margin-top:0;margin-bottom:0">Rex<br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> Colin King <colin.king@canonical.com><br>
<b>Sent:</b> Tuesday, March 13, 2018 9:22 PM<br>
<b>To:</b> Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Zhu, Rex; amd-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org<br>
<b>Cc:</b> kernel-janitors@vger.kernel.org; linux-kernel@vger.kernel.org<br>
<b>Subject:</b> [PATCH][next] drm/amd/pp: remove redundant pointer internal_buf</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Colin Ian King <colin.king@canonical.com><br>
<br>
The pointer internal_buf is assigned a value but the pointer is never<br>
read, hence it is redundant and can be removed.<br>
<br>
Cleans up clang warning:<br>
drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:630:2:<br>
warning: Value stored to 'internal_buf' is never read<br>
<br>
Signed-off-by: Colin Ian King <colin.king@canonical.com><br>
---<br>
drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c | 2 --<br>
1 file changed, 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c<br>
index 7394bb46b8b2..dcb151cabc00 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.c<br>
@@ -585,7 +585,6 @@ int smu7_setup_pwr_virus(struct pp_hwmgr *hwmgr)<br>
int smu7_init(struct pp_hwmgr *hwmgr)<br>
{<br>
struct smu7_smumgr *smu_data;<br>
- uint8_t *internal_buf;<br>
uint64_t mc_addr = 0;<br>
int r;<br>
/* Allocate memory for backend private data */<br>
@@ -627,7 +626,6 @@ int smu7_init(struct pp_hwmgr *hwmgr)<br>
&smu_data->header_buffer.kaddr);<br>
return -EINVAL;<br>
}<br>
- internal_buf = smu_data->smu_buffer.kaddr;<br>
smu_data->smu_buffer.mc_addr = mc_addr;<br>
<br>
if (smum_is_hw_avfs_present(hwmgr))<br>
-- <br>
2.15.1<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>