<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Since GPU reset is not enabled yet anyway, a timeout will just print a message, can we just change
<font size="2"><span style="font-size:11pt;">amdgpu_lockup_timeout</span></font> to
<font size="2"><span style="font-size:11pt;">MAX_SCHEDULE_TIMEOUT</span></font> until we enable GPU reset?</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Alex<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> Evan Quan <evan.quan@amd.com><br>
<b>Sent:</b> Friday, March 16, 2018 12:52:32 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Deucher, Alexander; Quan, Evan<br>
<b>Subject:</b> [PATCH] drm/amdgpu: no job timeout setting on compute queues</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Under some heavy computing test(dgemm) environment, it may takes<br>
the asic over 50+ seconds to finish the dispatched single job<br>
which will trigger the timeout. It's quite annoying although it<br>
does not seem to bring any real problems.<br>
As a quick workround, we choose to not enfoce the timeout<br>
setting on compute queues.<br>
<br>
Change-Id: I210011a90898617367e897a90e9f8fb2639281a3<br>
Signed-off-by: Evan Quan <evan.quan@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 4 +++-<br>
1 file changed, 3 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
index 008e198..455a81e 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
@@ -435,7 +435,9 @@ int amdgpu_fence_driver_init_ring(struct amdgpu_ring *ring,<br>
if (ring->funcs->type != AMDGPU_RING_TYPE_KIQ) {<br>
r = drm_sched_init(&ring->sched, &amdgpu_sched_ops,<br>
num_hw_submission, amdgpu_job_hang_limit,<br>
- msecs_to_jiffies(amdgpu_lockup_timeout), ring->name);<br>
+ (ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) ?<br>
+ MAX_SCHEDULE_TIMEOUT : msecs_to_jiffies(amdgpu_lockup_timeout),<br>
+ ring->name);<br>
if (r) {<br>
DRM_ERROR("Failed to create scheduler on ring %s.\n",<br>
ring->name);<br>
-- <br>
2.7.4<br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>