<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">That’s fine for me. Will update the patch accordingly.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Regards,<o:p></o:p></p>
<p class="MsoNormal">Evan<o:p></o:p></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Deucher, Alexander <br>
<b>Sent:</b> Saturday, March 17, 2018 1:17 AM<br>
<b>To:</b> Michel Dänzer <michel@daenzer.net>; Quan, Evan <Evan.Quan@amd.com><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div id="divtagdefaultwrapper">
<p><span style="font-size:12.0pt;color:black">How about something like this:<o:p></o:p></span></p>
<p><span style="font-size:10.0pt;color:black">/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
<p><span style="font-size:10.0pt;color:black">If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)
</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
<p><span style="font-size:12.0pt;color:black"> </span><span style="color:black">amdgpu_lockup_timeout</span><span style="font-size:12.0pt;color:black"> =
</span><span style="color:black">MAX_SCHEDULE_TIMEOUT;</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
<p><span style="color:black"><br>
<br>
</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
<p><span style="color:black">Alex</span><span style="font-size:12.0pt;color:black"><o:p></o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center">
<hr size="2" width="98%" align="center">
</div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>><br>
<b>Sent:</b> Friday, March 16, 2018 12:25:03 PM<br>
<b>To:</b> Deucher, Alexander; Quan, Evan<br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues</span>
<o:p></o:p></p>
<div>
<p class="MsoNormal"> <o:p></o:p></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal">On 2018-03-16 05:14 PM, Deucher, Alexander wrote:<br>
> Since GPU reset is not enabled yet anyway, a timeout will just print a<br>
> message, can we just change amdgpu_lockup_timeout to<br>
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?<br>
<br>
Wouldn't that be rather surprising for somebody who sets<br>
amdgpu.gpu_recovery=1 ?<br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="http://www.amd.com">
http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<o:p></o:p></p>
</div>
</div>
</div>
</body>
</html>