<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Rex Zhu <Rex.Zhu@amd.com><br> <b>Sent:</b> Wednesday, March 21, 2018 3:56:19 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Zhu, Rex<br> <b>Subject:</b> [PATCH] drm/amd/pp: Fix set wrong temperature range on smu7</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Fix the issue thermal irq was always triggered<br> for GPU under temperature range detected<br> <br> The low temp in default thermal policy<br> was set to -273. so need to use int type for the low temp.<br> <br> Change-Id: I1141b2698233ecd1e984b80eaf371966ab1aeef0<br> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com><br> ---<br> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c<br> index 4dd26eb..44527755 100644<br> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c<br> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c<br> @@ -308,7 +308,7 @@ int smu7_thermal_get_temperature(struct pp_hwmgr *hwmgr)<br> * @exception PP_Result_BadInput if the input data is not valid.<br> */<br> static int smu7_thermal_set_temperature_range(struct pp_hwmgr *hwmgr,<br> - uint32_t low_temp, uint32_t high_temp)<br> + int low_temp, int high_temp)<br> {<br> int low = SMU7_THERMAL_MINIMUM_ALERT_TEMP *<br> PP_TEMPERATURE_UNITS_PER_CENTIGRADES;<br> -- <br> 1.9.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </body> </html>