<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> That's fine with me too. Or make them DRM_INFO. Alex </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Liu, Monk Sent: Monday, March 26, 2018 8:55:51 AM To: Quan, Evan; Deucher, Alexander; Michel Dänzer Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues <div> </div> </div> <style>  </style> <div lang="ZH-CN" link="blue" vlink="purple"> <div class="x_WordSection1"> Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s Why change the logic in kmd side ? I don’t think it’s a good idea to disable the time out message for compute ring, we have virtualization end-user Still want those message printed out Can you do this way ? In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ? /Monk <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0cm 0cm 0cm"> From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Quan, Evan Sent: 2018年3月19日 9:47 To: Deucher, Alexander <Alexander.Deucher@amd.com>; Michel Dänzer <michel@daenzer.net> Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues </div> </div> That’s fine for me. Will update the patch accordingly. Regards, Evan <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0cm 0cm 0cm"> From: Deucher, Alexander Sent: Saturday, March 17, 2018 1:17 AM To: Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>> Cc: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues </div> </div> <div id="x_divtagdefaultwrapper"> How about something like this: /* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */ If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1) amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT; Alex </div> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> From: Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> Sent: Friday, March 16, 2018 12:25:03 PM To: Deucher, Alexander; Quan, Evan Cc: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues <div> </div> </div> <div> <div> On 2018-03-16 05:14 PM, Deucher, Alexander wrote: > Since GPU reset is not enabled yet anyway, a timeout will just print a > message, can we just change amdgpu_lockup_timeout to > MAX_SCHEDULE_TIMEOUT until we enable GPU reset? Wouldn't that be rather surprising for somebody who sets amdgpu.gpu_recovery=1 ? -- Earthling Michel Dänzer | <a href="http://www.amd.com"> http://www.amd.com</a> Libre software enthusiast | Mesa and X developer </div> </div> </div> </div> </body> </html>