<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<!--[if !mso]><style>v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style><![endif]--><style><!--
/* Font Definitions */
@font-face
{font-family:宋体;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:等线;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@等线";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"\@宋体";
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:微软雅黑;
panose-1:2 11 5 3 2 2 4 2 2 4;}
@font-face
{font-family:"\@微软雅黑";}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.xmsonormal, li.xmsonormal, div.xmsonormal
{mso-style-name:x_msonormal;
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.xmsonormal0, li.xmsonormal0, div.xmsonormal0
{mso-style-name:x_msonormal0;
margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
p.xmsochpdefault, li.xmsochpdefault, div.xmsochpdefault
{mso-style-name:x_msochpdefault;
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
span.xemailstyle18
{mso-style-name:x_emailstyle18;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.xemailstyle21
{mso-style-name:x_emailstyle21;
font-family:等线;
color:windowtext;}
span.EmailStyle23
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle26
{mso-style-type:personal-reply;
font-family:等线;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">Ok, fine by me<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">/Monk<o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Quan, Evan
<br>
<b>Sent:</b> 2018</span><span style="font-family:宋体">年</span><span lang="EN-US">3</span><span style="font-family:宋体">月</span><span lang="EN-US">27</span><span style="font-family:宋体">日</span><span lang="EN-US"> 9:34<br>
<b>To:</b> Deucher, Alexander <Alexander.Deucher@amd.com>; Liu, Monk <Monk.Liu@amd.com>; Michel Dänzer <michel@daenzer.net><br>
<b>Cc:</b> amd-gfx@lists.freedesktop.org; Koenig, Christian <Christian.Koenig@amd.com><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Hi Monk,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">That’s a fix reached after a long discussion(I believe you were in that mail thread).<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">50s is for the dgemm test. We are not sure whether it’s enough for other compute use case.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">If virtualization still needs these messages, I believe we can list that as an exception<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">- (ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) ?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ /* for non-sriov case, no timeout enforce on compute ring */<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">+ ((ring->funcs->type == AMDGPU_RING_TYPE_COMPUTE) && !amdgpu_sriov_vf(ring->adev)) ?<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US">Evan<o:p></o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Deucher, Alexander
<br>
<b>Sent:</b> Monday, March 26, 2018 11:20 PM<br>
<b>To:</b> Liu, Monk <<a href="mailto:Monk.Liu@amd.com">Monk.Liu@amd.com</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>>; Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>><br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div id="divtagdefaultwrapper">
<p><span lang="EN-US" style="color:black">That's fine with me too. Or make them DRM_INFO.<o:p></o:p></span></p>
<p><span lang="EN-US" style="color:black"><o:p> </o:p></span></p>
<p><span lang="EN-US" style="color:black">Alex<o:p></o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center"><span lang="EN-US">
<hr size="2" width="98%" align="center">
</span></div>
<div id="divRplyFwdMsg">
<p class="MsoNormal"><b><span lang="EN-US" style="color:black">From:</span></b><span lang="EN-US" style="color:black"> Liu, Monk<br>
<b>Sent:</b> Monday, March 26, 2018 8:55:51 AM<br>
<b>To:</b> Quan, Evan; Deucher, Alexander; Michel Dänzer<br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues</span><span lang="EN-US">
<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">Besides, if some compute shader takes time more them 50 seconds, you can just set lockuptime out to 50s</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">Why change the logic in kmd side ?</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线"> </span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">I don</span><span style="font-size:10.5pt;font-family:等线">’<span lang="EN-US">t think it</span>’<span lang="EN-US">s a good idea to disable the time out message for compute ring,
we have virtualization end-user</span></span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">Still want those message printed out</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线"> </span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">Can you do this way ?</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">In amdgpu_job_timeout, you can use DRM_WARN to replace DRM_ERROR for the job belongs to CPC engine ?</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线"> </span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线">/Monk</span><span lang="EN-US"><o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US" style="font-size:10.5pt;font-family:等线"> </span><span lang="EN-US"><o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="xmsonormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>]
<b>On Behalf Of </b>Quan, Evan<br>
<b>Sent:</b> 2018</span><span style="font-family:"微软雅黑",sans-serif">年</span><span lang="EN-US">3</span><span style="font-family:"微软雅黑",sans-serif">月</span><span lang="EN-US">19</span><span style="font-family:"微软雅黑",sans-serif">日</span><span lang="EN-US"> 9:47<br>
<b>To:</b> Deucher, Alexander <<a href="mailto:Alexander.Deucher@amd.com">Alexander.Deucher@amd.com</a>>; Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>><br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> RE: [PATCH] drm/amdgpu: no job timeout setting on compute queues<o:p></o:p></span></p>
</div>
</div>
<p class="xmsonormal"><span lang="EN-US"> <o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US">That’s fine for me. Will update the patch accordingly.<o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US"> <o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US">Regards,<o:p></o:p></span></p>
<p class="xmsonormal"><span lang="EN-US">Evan<o:p></o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="xmsonormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Deucher, Alexander
<br>
<b>Sent:</b> Saturday, March 17, 2018 1:17 AM<br>
<b>To:</b> Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>>; Quan, Evan <<a href="mailto:Evan.Quan@amd.com">Evan.Quan@amd.com</a>><br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues<o:p></o:p></span></p>
</div>
</div>
<p class="xmsonormal"><span lang="EN-US"> <o:p></o:p></span></p>
<div id="x_divtagdefaultwrapper">
<p><span lang="EN-US" style="color:black">How about something like this:</span><span lang="EN-US"><o:p></o:p></span></p>
<p><span lang="EN-US" style="font-size:10.0pt;color:black">/* Disable timeout when GPU reset is disabled to avoid confusing timeout messages in the kernel log */</span><span lang="EN-US"><o:p></o:p></span></p>
<p><span lang="EN-US" style="font-size:10.0pt;color:black">If (amdgpu_gpu_recovery == 0 || amdgpu_gpu_recovery == -1)
</span><span lang="EN-US"><o:p></o:p></span></p>
<p><span lang="EN-US" style="color:black"> amdgpu_lockup_timeout = MAX_SCHEDULE_TIMEOUT;</span><span lang="EN-US"><o:p></o:p></span></p>
<p style="margin-bottom:12.0pt"><span lang="EN-US"><o:p> </o:p></span></p>
<p><span lang="EN-US" style="color:black">Alex</span><span lang="EN-US"><o:p></o:p></span></p>
</div>
<div class="MsoNormal" align="center" style="text-align:center"><span lang="EN-US">
<hr size="2" width="98%" align="center">
</span></div>
<div id="x_divRplyFwdMsg">
<p class="xmsonormal"><b><span lang="EN-US" style="color:black">From:</span></b><span lang="EN-US" style="color:black"> Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>><br>
<b>Sent:</b> Friday, March 16, 2018 12:25:03 PM<br>
<b>To:</b> Deucher, Alexander; Quan, Evan<br>
<b>Cc:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: no job timeout setting on compute queues</span><span lang="EN-US">
<o:p></o:p></span></p>
<div>
<p class="xmsonormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p class="xmsonormal"><span lang="EN-US">On 2018-03-16 05:14 PM, Deucher, Alexander wrote:<br>
> Since GPU reset is not enabled yet anyway, a timeout will just print a<br>
> message, can we just change amdgpu_lockup_timeout to<br>
> MAX_SCHEDULE_TIMEOUT until we enable GPU reset?<br>
<br>
Wouldn't that be rather surprising for somebody who sets<br>
amdgpu.gpu_recovery=1 ?<br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="http://www.amd.com">
http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>