<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">The spec claims it does and we use it for HDP flush...</p>
<p style="margin-top:0;margin-bottom:0">Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Emily Deng <Emily.Deng@amd.com><br>
<b>Sent:</b> Friday, March 30, 2018 4:24:08 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Deng, Emily<br>
<b>Subject:</b> [PATCH] drm/amdgpu/sdma4:fix sdma engine hang</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">The sdma doesn't support register write and wait in one command.<br>
Use this will make sdma engine hang.<br>
<br>
Signed-off-by: Emily Deng <Emily.Deng@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 9 +--------<br>
1 file changed, 1 insertion(+), 8 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c<br>
index 9ac28b2..84d148d 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c<br>
@@ -1178,13 +1178,6 @@ static void sdma_v4_0_ring_emit_reg_wait(struct amdgpu_ring *ring, uint32_t reg,<br>
sdma_v4_0_wait_reg_mem(ring, 0, 0, reg, 0, val, mask, 10);<br>
}<br>
<br>
-static void sdma_v4_0_ring_emit_reg_write_reg_wait(struct amdgpu_ring *ring,<br>
- uint32_t reg0, uint32_t reg1,<br>
- uint32_t ref, uint32_t mask)<br>
-{<br>
- sdma_v4_0_wait_reg_mem(ring, 0, 1, reg0, reg1, ref, mask, 10);<br>
-}<br>
-<br>
static int sdma_v4_0_early_init(void *handle)<br>
{<br>
struct amdgpu_device *adev = (struct amdgpu_device *)handle;<br>
@@ -1626,7 +1619,7 @@ static const struct amdgpu_ring_funcs sdma_v4_0_ring_funcs = {<br>
.pad_ib = sdma_v4_0_ring_pad_ib,<br>
.emit_wreg = sdma_v4_0_ring_emit_wreg,<br>
.emit_reg_wait = sdma_v4_0_ring_emit_reg_wait,<br>
- .emit_reg_write_reg_wait = sdma_v4_0_ring_emit_reg_write_reg_wait,<br>
+ .emit_reg_write_reg_wait = amdgpu_ring_emit_reg_write_reg_wait_helper,<br>
};<br>
<br>
static void sdma_v4_0_set_ring_funcs(struct amdgpu_device *adev)<br>
-- <br>
2.7.4<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>