<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top: 0px; margin-bottom: 0px;">Reviewed-by: Rex Zhu <Rex.Zhu@amd.com></p> <p style="margin-top: 0px; margin-bottom: 0px;"> </p> <p style="margin-top: 0px; margin-bottom: 0px;">Best Regards</p> <p style="margin-top: 0px; margin-bottom: 0px;">Rex<br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="width: 98%; display: inline-block;"> <div id="divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size: 11pt;"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Thursday, April 12, 2018 7:11 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu/powerplay: rename smu7_upload_mc_firmware</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size: 11pt;"> <div class="PlainText">It doesn't actually upload any firmware is just<br> checks the version. The actual upload happens in<br> the gmc modules.<br> <br> Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br> ---<br> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ++--<br> 1 file changed, 2 insertions(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c<br> index 97b7c2333f19..ed43dd39b5d6 100644<br> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c<br> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c<br> @@ -4071,7 +4071,7 @@ static int smu7_check_states_equal(struct pp_hwmgr *hwmgr,<br> return 0;<br> }<br> <br> -static int smu7_upload_mc_firmware(struct pp_hwmgr *hwmgr)<br> +static int smu7_check_mc_firmware(struct pp_hwmgr *hwmgr)<br> {<br> struct smu7_hwmgr *data = (struct smu7_hwmgr *)(hwmgr->backend);<br> <br> @@ -4200,7 +4200,7 @@ static int smu7_setup_asic_task(struct pp_hwmgr *hwmgr)<br> {<br> int tmp_result, result = 0;<br> <br> - smu7_upload_mc_firmware(hwmgr);<br> + smu7_check_mc_firmware(hwmgr);<br> <br> tmp_result = smu7_read_clock_registers(hwmgr);<br> PP_ASSERT_WITH_CODE((0 == tmp_result),<br> -- <br> 2.13.6<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a id="LPlnk742814" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <p></p> <div id="LPBorder_GT_15235035507610.8864175340081135" style="width: 100%; text-indent: 0px; overflow: auto; margin-bottom: 20px; display: inline-block;"> <table id="LPContainer_15235035507450.7563721087499751" role="presentation" style="width: 90%; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top-color: rgb(200, 200, 200); border-bottom-color: rgb(200, 200, 200); border-top-width: 1px; border-bottom-width: 1px; border-top-style: dotted; border-bottom-style: dotted; position: relative; background-color: rgb(255, 255, 255);" cellspacing="0"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_15235035507490.05238852005809225" style="padding: 0px; vertical-align: top; display: table-cell; position: relative;" colspan="2"> <div id="LPRemovePreviewContainer_15235035507490.5064380115241844" style="float: right;"> </div> <div id="LPTitle_15235035507490.9189891582732629" style="top: 0px; color: rgb(0, 120, 215); line-height: 21px; font-family: "wf_segoe-ui_light", "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 21px; font-weight: 400;"> <a id="LPUrlAnchor_15235035507530.9518651314395661" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15235035507530.20486925298627484" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); line-height: 14px; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; font-weight: 400;"> lists.freedesktop.org</div> <div id="LPDescription_15235035507570.3744978834834676" style="color: rgb(102, 102, 102); line-height: 20px; overflow: hidden; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; font-weight: 400; display: block; max-height: 100px;"> Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.</div> </td> </tr> </tbody> </table> </div> <p></p> <br> <br> </div> </span></font></div> </div> </div> </body> </html>