<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div> <div dir="auto"> <div>Hi Ray,<br> <div class="x_gmail_extra"><br> <div class="x_gmail_quote">Am 23.04.2018 11:47 schrieb Huang Rui <ray.huang@amd.com>:<br type="attribution"> <blockquote class="x_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex"> <div><font size="2"><span style="font-size:11pt"> <div>On Fri, Apr 20, 2018 at 05:59:16PM +0800, Koenig, Christian wrote:<br> > Am 20.04.2018 um 11:40 schrieb Huang Rui:<br> > > "aaabaf4 drm/amdgpu: defer test IBs on the rings at boot (V3)"<br> > > Above patch defers the execution of gfx/compute ib tests. However, at that time,<br> > > the gfx may already go into idle state. If "idle" gfx receives command<br> > > submission, it will get hang in the system. So we must add is_gfx_on checking at<br> > > start of ib tests.<br> > <br> > Do I see that right that you just skip the IB test when the GFX block is <br> > already turned of? In this case that would be a clear NAK.<br> > <br> > BTW: How do you detect that we need to turn GFX on again?<br> <br> Christian, I know point. But there is a hang issue if we would like try to<br> disable/enable gfxoff with SMC message at runtime. Actually, I am trying to<br> find a good sequence to fix it. After that, I can even expose an debugfs<br> interface to configure that. So I have to skip the test for the moment when<br> gfx is in "idle".<br> </div> </span></font></div> </blockquote> </div> </div> </div> <div dir="auto"><br> </div> <div dir="auto">Working around that issue for the moment is ok, but please note that explicitly in both the commit message and a code comment.</div> <div dir="auto"><br> </div> <div dir="auto">But don't you run into the same problem when the UMD starts to submit commands?</div> <div dir="auto"><br> </div> <div dir="auto">I mean the idea of the IB test is that you "simulate" an userspace command submission and see if it works.</div> <div dir="auto"><br> </div> <div dir="auto">Regards,</div> <div dir="auto">Christian.</div> <div dir="auto"><br> </div> <div dir="auto"> <div class="x_gmail_extra"> <div class="x_gmail_quote"> <blockquote class="x_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex"> <div><font size="2"><span style="font-size:11pt"> <div><br> Thanks,<br> Ray<br> </div> </span></font></div> </blockquote> </div> <br> </div> </div> </div> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Fri, Apr 20, 2018 at 05:59:16PM +0800, Koenig, Christian wrote:<br> > Am 20.04.2018 um 11:40 schrieb Huang Rui:<br> > > "aaabaf4 drm/amdgpu: defer test IBs on the rings at boot (V3)"<br> > > Above patch defers the execution of gfx/compute ib tests. However, at that time,<br> > > the gfx may already go into idle state. If "idle" gfx receives command<br> > > submission, it will get hang in the system. So we must add is_gfx_on checking at<br> > > start of ib tests.<br> > <br> > Do I see that right that you just skip the IB test when the GFX block is <br> > already turned of? In this case that would be a clear NAK.<br> > <br> > BTW: How do you detect that we need to turn GFX on again?<br> <br> Christian, I know point. But there is a hang issue if we would like try to<br> disable/enable gfxoff with SMC message at runtime. Actually, I am trying to<br> find a good sequence to fix it. After that, I can even expose an debugfs<br> interface to configure that. So I have to skip the test for the moment when<br> gfx is in "idle".<br> <br> Thanks,<br> Ray<br> </div> </span></font> </body> </html>