<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">On 04/25/2018 11:29 AM, Eric W. Biederman wrote: </div> <blockquote type="cite" cite="mid:87a7trwbh0.fsf@xmission.com"> <blockquote type="cite" style="color: #000000;"> <pre wrap="">Another issue is changing wait_event_killable to wait_event_timeout where I need to understand what TO value is acceptable for all the drivers using the scheduler, or maybe it should come as a property of drm_sched_entity. </pre> </blockquote> <pre wrap="">It would not surprise me if you could pick a large value like 1 second and issue a warning if that time outever triggers. It sounds like the condition where we wait indefinitely today is because something went wrong in the driver.</pre> </blockquote> We wait here for all GPU jobs in flight which belong to the dying entity to complete. The driver submits the GPU jobs but the content of the job might be is not under driver's control and could take long time to finish or even hang (e.g. graphic or compute shader) , I guess that why originally the wait is indefinite. Andrey <blockquote type="cite" cite="mid:87a7trwbh0.fsf@xmission.com"> <pre wrap=""> Eric </pre> </blockquote> </body> </html>