<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> Actually, we could arguably enable hawaii since it does not support a DAC and there are no mobile skus. Alex </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Harry Wentland <harry.wentland@amd.com> Sent: Thursday, May 3, 2018 3:45:30 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Subject: [PATCH] drm/amdgpu: Don't default to DC support for Kaveri and older <div> </div> </div> <div class="BodyFragment"> <div class="PlainText">We've had a number of users report failures to detect and light up display with DC with LVDS and VGA. These connector types are not currently supported with DC. I'd like to add support but unfortunately don't have a system with LVDS or VGA available. In order not to cause regressions we should probably fallback to the non-DC driver for ASICs that support VGA and LVDS. These ASICs are: * Hawaii * Bonaire * Kabini * Kaveri ASIC support can always be force enabled with amdgpu.dc=1 Signed-off-by: Harry Wentland <harry.wentland@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 887f7c9e84e0..66d8b96a04ac 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -2144,6 +2144,14 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type) case CHIP_HAWAII: case CHIP_KAVERI: case CHIP_KABINI: + /* + * We have systems in the wild with these ASICs that require + * LVDS and VGA support which is not supported with DC. + * + * Fallback to the non-DC driver here by default so as not to + * cause regressions. + */ + return amdgpu_dc > 0; case CHIP_MULLINS: case CHIP_CARRIZO: case CHIP_STONEY: -- 2.17.0 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </div> </div> </body> </html>