<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">You need to include mullins as well. It's the same feature set as kabini.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Alex<br>
</p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Harry Wentland <harry.wentland@amd.com><br>
<b>Sent:</b> Monday, May 7, 2018 7:24 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org; Deucher, Alexander<br>
<b>Cc:</b> Wentland, Harry<br>
<b>Subject:</b> [PATCH v2] drm/amdgpu: Don't default to DC support for Kaveri and older</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">We've had a number of users report failures to detect and light up<br>
display with DC with LVDS and VGA. These connector types are not<br>
currently supported with DC. I'd like to add support but unfortunately<br>
don't have a system with LVDS or VGA available.<br>
<br>
In order not to cause regressions we should probably fallback to the<br>
non-DC driver for ASICs that support VGA and LVDS.<br>
<br>
These ASICs are:<br>
* Bonaire<br>
* Kabini<br>
* Kaveri<br>
<br>
ASIC support can always be force enabled with amdgpu.dc=1<br>
<br>
v2: Keep Hawaii on DC<br>
<br>
Signed-off-by: Harry Wentland <harry.wentland@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 10 +++++++++-<br>
1 file changed, 9 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
index 887f7c9e84e0..0a23134147b7 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c<br>
@@ -2141,9 +2141,17 @@ bool amdgpu_device_asic_has_dc_support(enum amd_asic_type asic_type)<br>
switch (asic_type) {<br>
#if defined(CONFIG_DRM_AMD_DC)<br>
case CHIP_BONAIRE:<br>
- case CHIP_HAWAII:<br>
case CHIP_KAVERI:<br>
case CHIP_KABINI:<br>
+ /*<br>
+ * We have systems in the wild with these ASICs that require<br>
+ * LVDS and VGA support which is not supported with DC.<br>
+ *<br>
+ * Fallback to the non-DC driver here by default so as not to<br>
+ * cause regressions.<br>
+ */<br>
+ return amdgpu_dc > 0;<br>
+ case CHIP_HAWAII:<br>
case CHIP_MULLINS:<br>
case CHIP_CARRIZO:<br>
case CHIP_STONEY:<br>
-- <br>
2.17.0<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk614702" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>