<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body bgcolor="white" lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi Christian,<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"> Thanks for your advice, will send a modify patch later.<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><b><span style="font-size:9.0pt;color:#1F497D">Best Wishes,<o:p></o:p></span></b></p> <p class="MsoNormal"><b><span style="font-size:9.0pt;color:#1F497D">Emily Deng</span></b><b><i><span style="font-family:仿宋;color:#1F497D"><o:p></o:p></span></i></b></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext"> Koenig, Christian <br> <b>Sent:</b> Friday, May 18, 2018 6:36 PM<br> <b>To:</b> Deng, Emily <Emily.Deng@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div> <p class="MsoNormal">Ah! So we have one RCU grace period caused by the scheduler fence and another one from the hardware fence.<br> <br> Thanks for explaining that once more, that was really not obvious from reading the code.<br> <br> But this means we could we also fix it by moving the "dma_fence_put(fence->parent);" from drm_sched_fence_free() into drm_sched_fence_release_scheduled() directly before the call_rcu(), can't we?<br> <br> I think that would be cleaner, cause otherwise every driver using the GPU scheduler would need that workaround.<br> <br> And drm_sched_fence_release_scheduled() is only called when the reference count becomes zero, so when anybody accesses the structure after that then that would be a bug as well.<br> <br> Thanks,<br> Christian.<br> <br> Am 18.05.2018 um 11:56 schrieb Deng, Emily:<o:p></o:p></p> </div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">Hi Christian,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> When we free an IB fence, we first call one call_rcu in drm_sched_fence_release_scheduled as the call trace one, then after the call trace one,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">we call the call_rcu second in the amdgpu_fence_release in call trace two, as below.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt"> </span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">The kmem_cache_free(amdgpu_fence_slab, fence)'s call trace as below:<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> 1.drm_sched_entity_fini -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> drm_sched_entity_cleanup -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> dma_fence_put(entity->last_scheduled) -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> drm_sched_fence_release_finished -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> drm_sched_fence_release_scheduled -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> call_rcu(&fence->finished.rcu, </span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:red">drm_sched_fence_free</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> 2.</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:red">drm_sched_fence_free</span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> dma_fence_put(fence->parent) -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> amdgpu_fence_release -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> call_rcu(&f->rcu, amdgpu_fence_free) -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> kmem_cache_free(amdgpu_fence_slab, fence);<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt"> </span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> -----Original Message-----<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> From: Koenig, Christian<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> Sent: Friday, May 18, 2018 5:46 PM<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> To: Deng, Emily <a href="mailto:Emily.Deng@amd.com"><Emily.Deng@amd.com></a>; <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> Subject: Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> Ok, I'm lost where do we use call_rcu() twice? Cause that sounds incorrect in<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> the first place.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> Christian.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> <o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> Am 18.05.2018 um 11:41 schrieb Deng, Emily:<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> > Ping......<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> ><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> > Best Wishes,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> > Emily Deng<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> ><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> ><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> ><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> ><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> -----Original Message-----<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> From: amd-gfx [<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">mailto:amd-gfx-bounces@lists.freedesktop.org</a>] On<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Behalf Of Deng, Emily<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Sent: Friday, May 18, 2018 11:20 AM<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> To: Koenig, Christian <<a href="mailto:Christian.Koenig@amd.com">Christian.Koenig@amd.com</a>>; amd-<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> <a href="mailto:gfx@lists.freedesktop.org">gfx@lists.freedesktop.org</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Subject: RE: [PATCH] drm/amdgpu: add rcu_barrier after entity fini<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Hi Christian,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Yes, it has already one rcu_barrier, but it has called twice<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> call_rcu, so the one rcu_barrier just could barrier one call_rcu some time.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> After I added another rcu_barrier, the kernel issue will disappear.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Best Wishes,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> Emily Deng<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> -----Original Message-----<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> From: Christian König [<a href="mailto:ckoenig.leichtzumerken@gmail.com">mailto:ckoenig.leichtzumerken@gmail.com</a>]<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> Sent: Thursday, May 17, 2018 7:08 PM<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> To: Deng, Emily <<a href="mailto:Emily.Deng@amd.com">Emily.Deng@amd.com</a>>; <a href="mailto:amd-gfx@lists.freedesktop.org">amd-</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> <a href="mailto:gfx@lists.freedesktop.org">gfx@lists.freedesktop.org</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> Subject: Re: [PATCH] drm/amdgpu: add rcu_barrier after entity fini<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> Am 17.05.2018 um 12:03 schrieb Emily Deng:<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> To free the fence from the amdgpu_fence_slab, need twice call_rcu,<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> to avoid the amdgpu_fence_slab_fini call<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> kmem_cache_destroy(amdgpu_fence_slab) before<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> kmem_cache_free(amdgpu_fence_slab, fence), add rcu_barrier after<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> drm_sched_entity_fini.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> The kmem_cache_free(amdgpu_fence_slab, fence)'s call trace as<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> below:<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> 1.drm_sched_entity_fini -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> drm_sched_entity_cleanup -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> dma_fence_put(entity->last_scheduled) -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> drm_sched_fence_release_finished -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> drm_sched_fence_release_scheduled<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> -> call_rcu(&fence->finished.rcu, drm_sched_fence_free)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> 2.drm_sched_fence_free -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> dma_fence_put(fence->parent) -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> amdgpu_fence_release -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> call_rcu(&f->rcu, amdgpu_fence_free) -><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> kmem_cache_free(amdgpu_fence_slab, fence);<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> v2:put the barrier before the kmem_cache_destroy<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> Change-Id: I8dcadd3372f97e72461bf46b41cc26d90f09b8df<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> Signed-off-by: Emily Deng <<a href="mailto:Emily.Deng@amd.com">Emily.Deng@amd.com</a>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> ---<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> 1 file changed, 1 insertion(+)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> index 39ec6b8..42be65b 100644<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> @@ -69,6 +69,7 @@ int amdgpu_fence_slab_init(void)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> void amdgpu_fence_slab_fini(void)<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> {<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> rcu_barrier();<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> + rcu_barrier();<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> Well, you should have noted that there is already an rcu_barrier<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> here and adding another one shouldn't have any additional effect. So<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> your explanation and the proposed solution doesn't make to much<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> sense.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> I think the problem you run into is rather that the fence is<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> reference counted and might live longer than the module who created it.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> Complicated issue, one possible solution would be to release<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> fence->parent earlier in the scheduler fence but that doesn't sound<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> fence->like<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> a general purpose solution.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>> Christian.<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> kmem_cache_destroy(amdgpu_fence_slab);<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> }<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >>>> /*<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> _______________________________________________<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> amd-gfx mailing list<o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">> >> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt"> </span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p> </div> <div> <p class="MsoNormal"><span style="font-size:11.0pt"> </span><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"><o:p></o:p></span></p> </div> </blockquote> <p class="MsoNormal"><o:p> </o:p></p> </div> </div> </body> </html>