<div dir="auto">Acked-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>><div dir="auto"> </div><div dir="auto">Marek</div></div> <div class="gmail_quote"><div dir="ltr">On Fri, Jun 15, 2018, 4:03 AM zhoucm1 <<a href="mailto:zhoucm1@amd.com">zhoucm1@amd.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Marek, Can I get your RB or Acked on this patches? Since these info are reported to UMD. Thanks, David Zhou On 2018年06月15日 15:22, zhoucm1 wrote: > > > On 2018年06月15日 15:16, Zhang, Jerry wrote: >>> -----Original Message----- >>> From: amd-gfx [mailto:<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" target="_blank" rel="noreferrer">amd-gfx-bounces@lists.freedesktop.org</a>] On >>> Behalf Of >>> Christian K?nig >>> Sent: Friday, June 15, 2018 15:09 >>> To: Zhou, David(ChunMing) <<a href="mailto:David1.Zhou@amd.com" target="_blank" rel="noreferrer">David1.Zhou@amd.com</a>>; amd- >>> <a href="mailto:gfx@lists.freedesktop.org" target="_blank" rel="noreferrer">gfx@lists.freedesktop.org</a> >>> Cc: Olsak, Marek <<a href="mailto:Marek.Olsak@amd.com" target="_blank" rel="noreferrer">Marek.Olsak@amd.com</a>>; Ryan, Sean <<a href="mailto:Sean.Ryan@amd.com" target="_blank" rel="noreferrer">Sean.Ryan@amd.com</a>> >>> Subject: Re: [PATCH] drm/amdgpu: update ib_start/size_alignment same as >>> windows used >>> >>> Am 15.06.2018 um 08:45 schrieb Chunming Zhou: >>>> PAGE_SIZE for start_alignment is far much than hw requirement, And >>>> now, update to expereince value from window side. >>>> >>>> Change-Id: I08a7e72076386c32faf36ec4812b30e68dde23e5 >>>> Signed-off-by: Chunming Zhou <<a href="mailto:david1.zhou@amd.com" target="_blank" rel="noreferrer">david1.zhou@amd.com</a>> >>> Acked-by: Christian König <<a href="mailto:christian.koenig@amd.com" target="_blank" rel="noreferrer">christian.koenig@amd.com</a>> >> Acked-by: Junwei Zhang <<a href="mailto:Jerry.Zhang@amd.com" target="_blank" rel="noreferrer">Jerry.Zhang@amd.com</a>> >> >> BTW, any issue it fixes? > Yes, as talked in internal brahma list " whether ib_start_alignment is > proper", which fixes some PAL assert checking. > > Regards, > David Zhou >> >> Jerry >> >>>> --- >>>> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 28 >>>> ++++++++++++++--------- >>> ----- >>>> 1 file changed, 14 insertions(+), 14 deletions(-) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c >>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c >>>> index 392dd24e83f5..d041dddaad0c 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c >>>> @@ -329,35 +329,35 @@ static int amdgpu_info_ioctl(struct >>>> drm_device *dev, >>> void *data, struct drm_file >>>> type = AMD_IP_BLOCK_TYPE_GFX; >>>> for (i = 0; i < adev->gfx.num_gfx_rings; i++) >>>> ring_mask |= ((adev->gfx.gfx_ring[i].ready ? 1 : 0) >>> << i); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> - ib_size_alignment = 8; >>>> + ib_start_alignment = 32; >>>> + ib_size_alignment = 32; >>>> break; >>>> case AMDGPU_HW_IP_COMPUTE: >>>> type = AMD_IP_BLOCK_TYPE_GFX; >>>> for (i = 0; i < adev->gfx.num_compute_rings; i++) >>>> ring_mask |= ((adev->gfx.compute_ring[i].ready ? >>> 1 : 0) << i); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> - ib_size_alignment = 8; >>>> + ib_start_alignment = 32; >>>> + ib_size_alignment = 32; >>>> break; >>>> case AMDGPU_HW_IP_DMA: >>>> type = AMD_IP_BLOCK_TYPE_SDMA; >>>> for (i = 0; i < adev->sdma.num_instances; i++) >>>> ring_mask |= ((adev- >>>> sdma.instance[i].ring.ready ? 1 : 0) << i); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> - ib_size_alignment = 1; >>>> + ib_start_alignment = 256; >>>> + ib_size_alignment = 4; >>>> break; >>>> case AMDGPU_HW_IP_UVD: >>>> type = AMD_IP_BLOCK_TYPE_UVD; >>>> for (i = 0; i < adev->uvd.num_uvd_inst; i++) >>>> ring_mask |= ((adev->uvd.inst[i].ring.ready ? 1 >>>> : 0) >>> << i); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> - ib_size_alignment = 16; >>>> + ib_start_alignment = 64; >>>> + ib_size_alignment = 64; >>>> break; >>>> case AMDGPU_HW_IP_VCE: >>>> type = AMD_IP_BLOCK_TYPE_VCE; >>>> for (i = 0; i < adev->vce.num_rings; i++) >>>> ring_mask |= ((adev->vce.ring[i].ready ? 1 : 0) << >>> i); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> + ib_start_alignment = 4; >>>> ib_size_alignment = 1; >>>> break; >>>> case AMDGPU_HW_IP_UVD_ENC: >>>> @@ -367,26 +367,26 @@ static int amdgpu_info_ioctl(struct >>>> drm_device *dev, >>> void *data, struct drm_file >>>> ring_mask |= >>>> ((adev->uvd.inst[i].ring_enc[j].ready ? 1 : >>> 0) << >>>> (j + i * adev->uvd.num_enc_rings)); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> - ib_size_alignment = 1; >>>> + ib_start_alignment = 64; >>>> + ib_size_alignment = 64; >>>> break; >>>> case AMDGPU_HW_IP_VCN_DEC: >>>> type = AMD_IP_BLOCK_TYPE_VCN; >>>> ring_mask = adev->vcn.ring_dec.ready ? 1 : 0; >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> + ib_start_alignment = 16; >>>> ib_size_alignment = 16; >>>> break; >>>> case AMDGPU_HW_IP_VCN_ENC: >>>> type = AMD_IP_BLOCK_TYPE_VCN; >>>> for (i = 0; i < adev->vcn.num_enc_rings; i++) >>>> ring_mask |= ((adev->vcn.ring_enc[i].ready ? 1 : 0) >>> << i); >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> + ib_start_alignment = 64; >>>> ib_size_alignment = 1; >>>> break; >>>> case AMDGPU_HW_IP_VCN_JPEG: >>>> type = AMD_IP_BLOCK_TYPE_VCN; >>>> ring_mask = adev->vcn.ring_jpeg.ready ? 1 : 0; >>>> - ib_start_alignment = AMDGPU_GPU_PAGE_SIZE; >>>> + ib_start_alignment = 16; >>>> ib_size_alignment = 16; >>>> break; >>>> default: >>> _______________________________________________ >>> amd-gfx mailing list >>> <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" rel="noreferrer">amd-gfx@lists.freedesktop.org</a> >>> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> > > _______________________________________________ > amd-gfx mailing list > <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" rel="noreferrer">amd-gfx@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank" rel="noreferrer">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </blockquote></div>