<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">I was going to say the same thing. I think it would be better to add it to the ppfeature mask for consistency.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Alex<br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Zhu, Rex <Rex.Zhu@amd.com><br> <b>Sent:</b> Tuesday, June 26, 2018 7:10:52 AM<br> <b>To:</b> Michel Dänzer<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode</font> <div> </div> </div> <meta content="text/html; charset=utf-8"> <meta name="x_Generator" content="Microsoft Exchange Server"> <style>  </style> <div> <div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> Evev when enabled this feature by default,we still need a way to disable it easily for triage issue maybe related to stutter mode.<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> as this feature is related to power saving. so we may add a bit mask in parameter ppfeaturemask.<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> Best Regards<br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> Rex<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> 获取 <a href="https://aka.ms/ghei36">Outlook for Android</a></div> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Michel Dänzer <michel@daenzer.net><br> <b>Sent:</b> Tuesday, June 26, 2018 6:38:14 PM<br> <b>To:</b> Zhu, Rex<br> <b>Cc:</b> Zhu, Rex; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 1/2] drm/amdgpu: Add module parameter stutter_mode</font> <div> </div> </div> </div> <font size="2"><span style="font-size:11pt"> <div class="x_PlainText">On 2018-06-26 12:23 PM, rex zhu wrote:<br> > Add new parameter to control stutter mode enable/disable.<br> > <br> > Enable stutter mode can save power in low DRAM use cases<br> > including but not limited to productivity application use,<br> > web browsing, and video playback.<br> <br> We already have too many module parameters. Do we really need yet<br> another one for this? Can't stutter mode just automatically be enabled<br> when appropriate?<br> <br> <br> -- <br> Earthling Michel Dänzer | <a href="http://www.amd.com"> http://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </body> </html>