<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">I wonder how '#if 0' made its way upstream, but besides this</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Slava Abramov <slava.abramov@amd.com></p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Michel Dänzer <michel@daenzer.net><br>
<b>Sent:</b> Wednesday, June 27, 2018 12:39:40 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Michel Dänzer <michel.daenzer@amd.com><br>
<br>
This has always been disabled, no need to keep it.<br>
<br>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com><br>
---<br>
 src/drmmode_display.c | 12 ------------<br>
 1 file changed, 12 deletions(-)<br>
<br>
diff --git a/src/drmmode_display.c b/src/drmmode_display.c<br>
index 1563417a7..5fe49b607 100644<br>
--- a/src/drmmode_display.c<br>
+++ b/src/drmmode_display.c<br>
@@ -2459,15 +2459,6 @@ static const xf86OutputFuncsRec drmmode_output_funcs = {<br>
         .create_resources = drmmode_output_create_resources,<br>
         .set_property = drmmode_output_set_property,<br>
         .get_property = drmmode_output_get_property,<br>
-#if 0<br>
-<br>
-       .save = drmmode_crt_save,<br>
-       .restore = drmmode_crt_restore,<br>
-       .mode_fixup = drmmode_crt_mode_fixup,<br>
-       .prepare = drmmode_output_prepare,<br>
-       .mode_set = drmmode_crt_mode_set,<br>
-       .commit = drmmode_output_commit,<br>
-#endif<br>
         .detect = drmmode_output_detect,<br>
         .mode_valid = drmmode_output_mode_valid,<br>
 <br>
@@ -3470,9 +3461,6 @@ Bool drmmode_setup_colormap(ScreenPtr pScreen, ScrnInfoPtr pScrn)<br>
                     !xf86HandleColormaps(pScreen, 256, 10,<br>
                                          NULL, NULL,<br>
                                          CMAP_PALETTED_TRUECOLOR<br>
-#if 0                          /* This option messes up text mode! (eich@suse.de) */<br>
-                                        | CMAP_LOAD_EVEN_IF_OFFSCREEN<br>
-#endif<br>
                                          | CMAP_RELOAD_ON_MODE_SWITCH))<br>
                         return FALSE;<br>
         }<br>
-- <br>
2.18.0<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>