<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Hi Alex,</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">What's your opinion about Michel's suggestion? <br> </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Thanks,</p> <p style="margin-top:0;margin-bottom:0">Sonny<br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Michel Dänzer <michel@daenzer.net><br> <b>Sent:</b> Thursday, June 28, 2018 4:39:57 AM<br> <b>To:</b> Jiang, Sonny<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: update documentation for amdgpu_drv.c</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText"><br> Hi Sonny,<br> <br> <br> would it be possible to put the documentation of each parameter directly<br> next to its definition / declaration? Otherwise, I'm afraid the<br> documentation will quickly fall out of date WRT the code.<br> <br> <br> > +/**<br> > + * DOC: module_parameters<br> <br> Otherwise, this needs to be referenced in Documentation/gpu/amdgpu.rst,<br> or the contents of this comment don't show up in the generated<br> documentation.<br> <br> <br> -- <br> Earthling Michel Dänzer | <a href="http://www.amd.com"> http://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> </div> </span></font></div> </body> </html>