<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> Michel, <div><br> </div> <div>My review is only for the first patch. </div> <div><br> </div> <div><br> </div> <div>Slava</div> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Michel Dänzer <michel@daenzer.net><br> <b>Sent:</b> Thursday, June 28, 2018 4:26:28 AM<br> <b>To:</b> Abramov, Slava<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On 2018-06-27 08:29 PM, Abramov, Slava wrote:<br> > I wonder how '#if 0' made its way upstream, but besides this<br> <br> It was inherited from xf86-video-ati, where it's been in<br> drmmode_display.c since that file was first added (in 2009).<br> <br> <br> > Reviewed-by: Slava Abramov <slava.abramov@amd.com><br> <br> Thanks Slava (and Alex)! Is that only for this patch, or also for patch<br> 2 of the series?<br> <br> <br> -- <br> Earthling Michel Dänzer | <a href="http://www.amd.com"> http://www.amd.com</a><br> Libre software enthusiast | Mesa and X developer<br> </div> </span></font></div> </body> </html>