<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Do we need to maintain the uvd/vce pg state in pp?</p> <p style="margin-top:0;margin-bottom:0">uvd/vce have maintained the pg state by themselves.</p> <p style="margin-top:0;margin-bottom:0">pp only provide an interface for uvd/vce/gfx/mmhub to power up/down the ip through smu if smu supported, concurrently enable/disable uvd/vce/mmhub dpm feature.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Best Regards</p> <p style="margin-top:0;margin-bottom:0">Rex </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br> <b>Sent:</b> Thursday, June 28, 2018 11:31 PM<br> <b>To:</b> Quan, Evan<br> <b>Cc:</b> amd-gfx list<br> <b>Subject:</b> Re: [PATCH] drm/amd/powerplay: initialize uvd/vce powergate status v3</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Wed, Jun 20, 2018 at 2:40 AM, Evan Quan <evan.quan@amd.com> wrote:<br> > On UVD/VCE dpm enabled/disabled, the powergate status will be<br> > set as false/true. So that we will not try to ungate/gate them(<br> > enable/disable their dpm) again.<br> ><br> > v2: added check for uvd/vce powergate status before gating<br> > v3: fix typo in description<br> ><br> > Change-Id: I569a5aa216b5e7d64a2b504f2ff98cc83ca802d5<br> > Signed-off-by: Evan Quan <evan.quan@amd.com><br> <br> <br> Does vega10 need a similar fix?<br> <br> Alex<br> <br> > ---<br> > drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 23 ++++++++++++++++++++++<br> > 1 file changed, 23 insertions(+)<br> ><br> > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br> > index 45c8f2d..28b172e 100644<br> > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br> > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br> > @@ -777,6 +777,21 @@ static int vega12_set_allowed_featuresmask(struct pp_hwmgr *hwmgr)<br> > return 0;<br> > }<br> ><br> > +static void vega12_init_powergate_state(struct pp_hwmgr *hwmgr)<br> > +{<br> > + struct vega12_hwmgr *data =<br> > + (struct vega12_hwmgr *)(hwmgr->backend);<br> > +<br> > + data->uvd_power_gated = true;<br> > + data->vce_power_gated = true;<br> > +<br> > + if (data->smu_features[GNLD_DPM_UVD].enabled)<br> > + data->uvd_power_gated = false;<br> > +<br> > + if (data->smu_features[GNLD_DPM_VCE].enabled)<br> > + data->vce_power_gated = false;<br> > +}<br> > +<br> > static int vega12_enable_all_smu_features(struct pp_hwmgr *hwmgr)<br> > {<br> > struct vega12_hwmgr *data =<br> > @@ -801,6 +816,8 @@ static int vega12_enable_all_smu_features(struct pp_hwmgr *hwmgr)<br> > }<br> > }<br> ><br> > + vega12_init_powergate_state(hwmgr);<br> > +<br> > return 0;<br> > }<br> ><br> > @@ -1985,6 +2002,9 @@ static void vega12_power_gate_vce(struct pp_hwmgr *hwmgr, bool bgate)<br> > {<br> > struct vega12_hwmgr *data = (struct vega12_hwmgr *)(hwmgr->backend);<br> ><br> > + if (data->vce_power_gated == bgate)<br> > + return 0;<br> > +<br> > data->vce_power_gated = bgate;<br> > vega12_enable_disable_vce_dpm(hwmgr, !bgate);<br> > }<br> > @@ -1993,6 +2013,9 @@ static void vega12_power_gate_uvd(struct pp_hwmgr *hwmgr, bool bgate)<br> > {<br> > struct vega12_hwmgr *data = (struct vega12_hwmgr *)(hwmgr->backend);<br> ><br> > + if (data->uvd_power_gated == bgate)<br> > + return 0;<br> > +<br> > data->uvd_power_gated = bgate;<br> > vega12_enable_disable_uvd_dpm(hwmgr, !bgate);<br> > }<br> > --<br> > 2.7.4<br> ><br> > _______________________________________________<br> > amd-gfx mailing list<br> > amd-gfx@lists.freedesktop.org<br> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk297351" class="OWAAutoLink" previewremoved="true"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15302317866560.7402201292218797" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15302317866530.6923541125707908" role="presentation" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_15302317866540.96951563183552" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_15302317866540.27701115588335345"></div> <div id="LPTitle_15302317866540.3920123678910694" style="top: 0px; color: rgb(0, 120, 215); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15302317866550.14476511036207396" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15302317866550.7183196487901087" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15302317866550.9720882814258935" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.</div> </td> </tr> </tbody> </table> </div> <br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk741007" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </div> </body> </html>