<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> indeed，I used 4.13 on the platform. let me have a try with the patch you mentioned<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> thinks<br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> jimqu<br> <br> </div> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> <div dir="auto" style="direction:ltr; margin:0; padding:0; font-family:sans-serif; font-size:11pt; color:black"> 获取 <a href="https://aka.ms/ghei36">Outlook for Android</a></div> <br> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Lukas Wunner <lukas@wunner.de><br> <b>Sent:</b> Friday, June 29, 2018 5:21:38 PM<br> <b>To:</b> Qu, Jim<br> <b>Cc:</b> alsa-devel@alsa-project.org; dri-devel@lists.freedesktop.org; Deucher, Alexander; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id</font> <div> </div> </div> </div> <font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Fri, Jun 29, 2018 at 08:55:40AM +0000, Qu, Jim wrote:<br> > When our dGPU does suspend by runtime pm. amdgpu driver for dgpu will<br> > also call vgaswtichroo to power off its audio. vgaswitchroo driver will<br> > find audio codec by vgaswitchroo dgpu client id(VGA_SWITCHEROO_DIS).<br> <br> That is no longer the case since v4.17. The HDA controller now runtime<br> suspends autonomously, see commit 07f4f97d7b4b ("vga_switcheroo: Use<br> device link for HDA controller").<br> <br> Your patch appears to be geared towards an older kernel version.<br> Please retest on the laptop in question with a v4.17+ kernel.<br> <br> <br> > I think the issue should be observed on both Intel+AMD or AMD+AMD<br> > platform which has the same HW configuration.<br> > <br> > 1.if dGPU has no audio codec. the issue should be always observed.<br> > 2.if both iGPU and dGPU has audio codecs, the issue should be random,<br> > it depends on the first audio found by vgaswitchroo driver is on iGPU<br> > or dGPU.<br> <br> On discrete AMD and Nvidia GPUs, the HDA controller is function 1 and<br> the GPU is function 0 in the same PCI slot.<br> <br> On Intel chipsets, the HDA controller and the GPU have completely<br> different PCI device numbers, e.g. the GPU might be 0000:00:02.0 and<br> the HDA controller might be 0000:00:1b.0.<br> <br> get_bound_vga() checks that the HDA controller is function 1 and there's<br> a GPU in function 0 of the same slot.<br> <br> Thus get_bound_vga() always returns NULL for an Intel HDA controller and<br> the controller is never registered with vga_switcheroo (which is fine).<br> <br> Thanks,<br> <br> Lukas<br> </div> </span></font> </body> </html>