<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Mhm, double checking that I now knew
why my memory fooled me: We use 0 as infinite timeout in radeon.<br>
<br>
Maybe we should change amdgpu to do the same and reject negative
values.<br>
<br>
Christian.<br>
<br>
Am 05.07.2018 um 16:54 schrieb Christian König:<br>
</div>
<blockquote type="cite"
cite="mid:131f66f1-8871-de93-2c3a-50b8c15cb9d8@amd.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="moz-cite-prefix">Sounds like my memory fooled me, but
we should document that as well.<br>
<br>
Christian.<br>
<br>
Am 05.07.2018 um 16:47 schrieb Jiang, Sonny:<br>
</div>
<blockquote type="cite"
cite="mid:CY4PR12MB1511F4BC97EABF20A34503D8FD400@CY4PR12MB1511.namprd12.prod.outlook.com">
<meta http-equiv="Content-Type" content="text/html;
charset=utf-8">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;"
dir="ltr">
<p style="margin-top:0;margin-bottom:0">Change it to,</p>
<div>Value 0 is invalidated, will be adjusted to 10000.
Negative values mean 'infinite timeout' (MAX_JIFFY_OFFSET).</div>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Thanks,</p>
<p style="margin-top:0;margin-bottom:0">Sonny<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
color="#000000" face="Calibri, sans-serif"><b>From:</b>
Christian König <a class="moz-txt-link-rfc2396E"
href="mailto:ckoenig.leichtzumerken@gmail.com"
moz-do-not-send="true"><ckoenig.leichtzumerken@gmail.com></a><br>
<b>Sent:</b> Thursday, July 5, 2018 3:30:28 AM<br>
<b>To:</b> Jiang, Sonny; <a
class="moz-txt-link-abbreviated"
href="mailto:amd-gfx@lists.freedesktop.org"
moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> Re: [PATCH v3] drm/amdgpu: update
documentation for amdgpu_drv.c</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span
style="font-size:11pt;">
<div class="PlainText">Am 04.07.2018 um 20:20 schrieb
Sonny Jiang:<br>
> [SNIP]<br>
> <br>
> +/**<br>
> + * DOC: lockup_timeout (int)<br>
> + * Set GPU scheduler timeout value in ms. It must
be > 0. The default is 10000.<br>
> + */<br>
> MODULE_PARM_DESC(lockup_timeout, "GPU lockup
timeout in ms > 0 (default 10000)");<br>
> module_param_named(lockup_timeout,
amdgpu_lockup_timeout, int, 0444);<br>
<br>
Actually the description here is incorrect, a value of 0
is handled as <br>
infinite timeout IIRC. Please fix while at it.<br>
<br>
Apart from that the patch is Acked-by: Christian König <br>
<a class="moz-txt-link-rfc2396E"
href="mailto:christian.koenig@amd.com"
moz-do-not-send="true"><christian.koenig@amd.com></a>.<br>
<br>
Christian.<br>
</div>
</span></font></div>
</blockquote>
<br>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</body>
</html>