<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, EmojiFont, "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Add Michel,</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">seems Michel found a similar issue. Please see the kern.log.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Best Regards</p> <p style="margin-top:0;margin-bottom:0">Rex</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Harry Wentland <harry.wentland@amd.com><br> <b>Sent:</b> Friday, July 6, 2018 9:32 PM<br> <b>To:</b> Christian König; amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Lipski, Mikita<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amd/display: make function tables const</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On 2018-07-06 08:22 AM, Christian König wrote:<br> > It is good practice to make global function tables const to avoid<br> > accidental override.<br> > <br> > Signed-off-by: Christian König <christian.koenig@amd.com><br> <br> Well, this is embarassing. Can't believe I didn't spot this.<br> <br> Series is<br> Reviewed-by: Harry Wentland <harry.wentland@amd.com><br> <br> Now I wonder where else we might have this issue. Time to review all of our other function pointers.<br> <br> Harry<br> <br> > ---<br> > drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 6 +++---<br> > drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c | 2 +-<br> > drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h | 2 +-<br> > 3 files changed, 5 insertions(+), 5 deletions(-)<br> > <br> > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c<br> > index bae752332a9f..85686d917636 100644<br> > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c<br> > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c<br> > @@ -729,7 +729,7 @@ static bool dce_mi_program_surface_flip_and_addr(<br> > return true;<br> > }<br> > <br> > -static struct mem_input_funcs dce_mi_funcs = {<br> > +static const struct mem_input_funcs dce_mi_funcs = {<br> > .mem_input_program_display_marks = dce_mi_program_display_marks,<br> > .allocate_mem_input = dce_mi_allocate_dmif,<br> > .free_mem_input = dce_mi_free_dmif,<br> > @@ -741,7 +741,7 @@ static struct mem_input_funcs dce_mi_funcs = {<br> > .mem_input_is_flip_pending = dce_mi_is_flip_pending<br> > };<br> > <br> > -static struct mem_input_funcs dce112_mi_funcs = {<br> > +static const struct mem_input_funcs dce112_mi_funcs = {<br> > .mem_input_program_display_marks = dce112_mi_program_display_marks,<br> > .allocate_mem_input = dce_mi_allocate_dmif,<br> > .free_mem_input = dce_mi_free_dmif,<br> > @@ -753,7 +753,7 @@ static struct mem_input_funcs dce112_mi_funcs = {<br> > .mem_input_is_flip_pending = dce_mi_is_flip_pending<br> > };<br> > <br> > -static struct mem_input_funcs dce120_mi_funcs = {<br> > +static const struct mem_input_funcs dce120_mi_funcs = {<br> > .mem_input_program_display_marks = dce120_mi_program_display_marks,<br> > .allocate_mem_input = dce_mi_allocate_dmif,<br> > .free_mem_input = dce_mi_free_dmif,<br> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c<br> > index 0564c8e31252..9b9fc3d96c07 100644<br> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c<br> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c<br> > @@ -1011,7 +1011,7 @@ void dce110_free_mem_input_v(<br> > {<br> > }<br> > <br> > -static struct mem_input_funcs dce110_mem_input_v_funcs = {<br> > +static const struct mem_input_funcs dce110_mem_input_v_funcs = {<br> > .mem_input_program_display_marks =<br> > dce_mem_input_v_program_display_marks,<br> > .mem_input_program_chroma_display_marks =<br> > diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h<br> > index 47f1dc5a43b7..da89c2edb07c 100644<br> > --- a/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h<br> > +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h<br> > @@ -64,7 +64,7 @@ struct stutter_modes {<br> > };<br> > <br> > struct mem_input {<br> > - struct mem_input_funcs *funcs;<br> > + const struct mem_input_funcs *funcs;<br> > struct dc_context *ctx;<br> > struct dc_plane_address request_address;<br> > struct dc_plane_address current_address;<br> > <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk757106" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15309280054370.5139627939483356" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15309280054340.885055010626419" role="presentation" cellspacing="0" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);"> <tbody> <tr valign="top" style="border-spacing: 0px;"> <td id="TextCell_15309280054350.09207141975106015" colspan="2" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;"> <div id="LPRemovePreviewContainer_15309280054350.5915454485299354"></div> <div id="LPTitle_15309280054360.5322745038679628" style="top: 0px; color: rgb(0, 120, 215); font-weight: normal; font-size: 21px; font-family: wf_segoe-ui_light, "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15309280054360.6263051860853015" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration: none;">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15309280054360.6664147003914225" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15309280054370.5356504301440415" style="display: block; color: rgb(102, 102, 102); font-weight: normal; font-family: wf_segoe-ui_normal, "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </div> </body> </html>