<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Hi Christian,</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0"></p> <p style="margin-top:0;margin-bottom:0">As I am ooo on vocation, Can display team help to check this issue or just revert the patch? </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">I verified on Polaris11 and Vega10. From pp side, <span style="font-size: 12pt;">this is no difference between tonga and polaris10.</span></p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Best Regards</p> <p style="margin-top:0;margin-bottom:0">Rex</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Sent:</b> Saturday, July 7, 2018 8:30 PM<br> <b>To:</b> Zhu, Rex; Wentland, Harry; amd-gfx@lists.freedesktop.org; Michel Dänzer<br> <b>Cc:</b> Lipski, Mikita<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amd/display: make function tables const</font> <div> </div> </div> <meta content="text/html; charset=Windows-1252"> <div style="background-color:#FFFFFF"> <div class="x_moz-cite-prefix">That's a completely different issue. I'm running into it with just a Tonga in my system.<br> <br> According to my bisecting the problematic patch seems to be:<br> <blockquote type="cite">commit 3fdadbfe1edf4168b2515083af5651c95aeb299d (refs/bisect/bad)<br> Author: Rex Zhu <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:rex.zhu@amd.com" id="LPlnk277154" previewremoved="true"> <rex.zhu@amd.com></a><br> Date: Thu Jul 5 19:22:50 2018 +0800<br> <br> drm/amd/pp: Implement get_performance_level for legacy dgpu<br> <br> display can get clock info through this function.<br> implement this function for vega10 and old asics.<br> from vega12, there is no power state management,<br> so need to add new interface to notify display<br> the clock info<br> <br> Reviewed-by: Alex Deucher <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:alexander.deucher@amd.com" id="LPlnk146122" previewremoved="true"> <alexander.deucher@amd.com></a><br> Signed-off-by: Rex Zhu <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:Rex.Zhu@amd.com" id="LPlnk302170" previewremoved="true"> <Rex.Zhu@amd.com></a><br> </blockquote> <br> Please fix and/or revert immediately, cause that is quite a show stopper for my testing.<br> <br> Thanks,<br> Christian.<br> <br> Am 07.07.2018 um 03:51 schrieb Zhu, Rex:<br> </div> <blockquote type="cite"> <div id="x_divtagdefaultwrapper" dir="ltr" style=""> <p style="margin-top:0; margin-bottom:0">Add Michel,</p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0">seems Michel found a similar issue. Please see the kern.log.</p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0">Best Regards</p> <p style="margin-top:0; margin-bottom:0">Rex</p> <br> <br> <div style="color:rgb(0,0,0)"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size:11pt"><b>From:</b> amd-gfx <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:amd-gfx-bounces@lists.freedesktop.org" id="LPlnk278165" previewremoved="true"> <amd-gfx-bounces@lists.freedesktop.org></a> on behalf of Harry Wentland <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:harry.wentland@amd.com" id="LPlnk85431" previewremoved="true"> <harry.wentland@amd.com></a><br> <b>Sent:</b> Friday, July 6, 2018 9:32 PM<br> <b>To:</b> Christian König; <a class="x_moz-txt-link-abbreviated OWAAutoLink" href="mailto:amd-gfx@lists.freedesktop.org" id="LPlnk393200" previewremoved="true"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Lipski, Mikita<br> <b>Subject:</b> Re: [PATCH 2/2] drm/amd/display: make function tables const</font> <div> </div> </div> <div class="x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_PlainText">On 2018-07-06 08:22 AM, Christian König wrote:<br> > It is good practice to make global function tables const to avoid<br> > accidental override.<br> > <br> > Signed-off-by: Christian König <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:christian.koenig@amd.com" id="LPlnk802671" previewremoved="true"> <christian.koenig@amd.com></a><br> <br> Well, this is embarassing. Can't believe I didn't spot this.<br> <br> Series is<br> Reviewed-by: Harry Wentland <a class="x_moz-txt-link-rfc2396E OWAAutoLink" href="mailto:harry.wentland@amd.com" id="LPlnk560847" previewremoved="true"> <harry.wentland@amd.com></a><br> <br> Now I wonder where else we might have this issue. Time to review all of our other function pointers.<br> <br> Harry<br> <br> > ---<br> > drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c | 6 +++---<br> > drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c | 2 +-<br> > drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h | 2 +-<br> > 3 files changed, 5 insertions(+), 5 deletions(-)<br> > <br> > diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c<br> > index bae752332a9f..85686d917636 100644<br> > --- a/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c<br> > +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_mem_input.c<br> > @@ -729,7 +729,7 @@ static bool dce_mi_program_surface_flip_and_addr(<br> > return true;<br> > }<br> > <br> > -static struct mem_input_funcs dce_mi_funcs = {<br> > +static const struct mem_input_funcs dce_mi_funcs = {<br> > .mem_input_program_display_marks = dce_mi_program_display_marks,<br> > .allocate_mem_input = dce_mi_allocate_dmif,<br> > .free_mem_input = dce_mi_free_dmif,<br> > @@ -741,7 +741,7 @@ static struct mem_input_funcs dce_mi_funcs = {<br> > .mem_input_is_flip_pending = dce_mi_is_flip_pending<br> > };<br> > <br> > -static struct mem_input_funcs dce112_mi_funcs = {<br> > +static const struct mem_input_funcs dce112_mi_funcs = {<br> > .mem_input_program_display_marks = dce112_mi_program_display_marks,<br> > .allocate_mem_input = dce_mi_allocate_dmif,<br> > .free_mem_input = dce_mi_free_dmif,<br> > @@ -753,7 +753,7 @@ static struct mem_input_funcs dce112_mi_funcs = {<br> > .mem_input_is_flip_pending = dce_mi_is_flip_pending<br> > };<br> > <br> > -static struct mem_input_funcs dce120_mi_funcs = {<br> > +static const struct mem_input_funcs dce120_mi_funcs = {<br> > .mem_input_program_display_marks = dce120_mi_program_display_marks,<br> > .allocate_mem_input = dce_mi_allocate_dmif,<br> > .free_mem_input = dce_mi_free_dmif,<br> > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c<br> > index 0564c8e31252..9b9fc3d96c07 100644<br> > --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c<br> > +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_mem_input_v.c<br> > @@ -1011,7 +1011,7 @@ void dce110_free_mem_input_v(<br> > {<br> > }<br> > <br> > -static struct mem_input_funcs dce110_mem_input_v_funcs = {<br> > +static const struct mem_input_funcs dce110_mem_input_v_funcs = {<br> > .mem_input_program_display_marks =<br> > dce_mem_input_v_program_display_marks,<br> > .mem_input_program_chroma_display_marks =<br> > diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h<br> > index 47f1dc5a43b7..da89c2edb07c 100644<br> > --- a/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h<br> > +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/mem_input.h<br> > @@ -64,7 +64,7 @@ struct stutter_modes {<br> > };<br> > <br> > struct mem_input {<br> > - struct mem_input_funcs *funcs;<br> > + const struct mem_input_funcs *funcs;<br> > struct dc_context *ctx;<br> > struct dc_plane_address request_address;<br> > struct dc_plane_address current_address;<br> > <br> _______________________________________________<br> amd-gfx mailing list<br> <a class="x_moz-txt-link-abbreviated OWAAutoLink" href="mailto:amd-gfx@lists.freedesktop.org" id="LPlnk502422" previewremoved="true">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk757106" class="x_OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15309280054370.5139627939483356" style="margin-bottom:20px; overflow:auto; width:100%; text-indent:0px" contenteditable="false"> <table id="LPContainer_15309280054340.885055010626419" cellspacing="0" style="width:90%; background-color:rgb(255,255,255); overflow:auto; padding-top:20px; padding-bottom:20px; margin-top:20px; border-top:1px dotted rgb(200,200,200); border-bottom:1px dotted rgb(200,200,200)"> <tbody> <tr valign="top" style="border-spacing:0px"> <td id="x_TextCell_15309280054350.09207141975106015" colspan="2" style="vertical-align:top; padding:0px; display:table-cell"> <div id="LPTitle_15309280054360.5322745038679628" style=""><a id="LPUrlAnchor_15309280054360.6263051860853015" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank" style="text-decoration:none">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15309280054360.6664147003914225" style="">lists.freedesktop.org</div> <div id="LPDescription_15309280054370.5356504301440415" style="">Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.</div> </td> </tr> </tbody> </table> </div> <br> <br> </div> </span></font></div> </div> </div> </blockquote> <br> </div> </div> </div> </body> </html>