<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"><span style="font-size:12pt;" id="divtagdefaultwrapper"></p>
<div style="margin-top:0;margin-bottom:0;"><font size="2" color="black" face="sans-serif"><span style="font-size:11pt;">Reviewed-by: Rex Zhu<</span></font><a href="mailto:rezhu@amd.com" target="_blank" rel="noopener noreferrer" data-auth="NotApplicable" id="LPlnk933400" previewremoved="true"><font size="2" face="sans-serif"><span style="font-size:11pt;" id="LPlnk933400">rezhu@amd.com</span></font></a><font size="2" color="black" face="sans-serif"><span style="font-size:11pt;">>
</span></font><font size="2" color="black" face="sans-serif"><span style="font-size:11pt;"><br>
</span></font></div>
<div style="margin-top:0;margin-bottom:0;"><br>
</div>
<div style="margin-top:0;margin-bottom:0;"><br>
</div>
<div style="margin-top:0;margin-bottom:0;">Best Regards</div>
<div style="margin-top:0;margin-bottom:0;">Rex</div>
</span><br>
<p></p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Alex Deucher <alexdeucher@gmail.com><br>
<b>Sent:</b> Thursday, July 19, 2018 5:08 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Deucher, Alexander<br>
<b>Subject:</b> [PATCH] drm/amdgpu/powerplay: use irq source defines for smu7 sources</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Use the newly added irq source defines rather than magic numbers<br>
for smu7 thermal interrupts.<br>
<br>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com><br>
---<br>
drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c | 7 ++++---<br>
1 file changed, 4 insertions(+), 3 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c<br>
index 8eea49e4c74d..2aab1b475945 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu_helper.c<br>
@@ -27,6 +27,7 @@<br>
#include "atom.h"<br>
#include "ivsrcid/thm/irqsrcs_thm_9_0.h"<br>
#include "ivsrcid/smuio/irqsrcs_smuio_9_0.h"<br>
+#include "ivsrcid/ivsrcid_vislands30.h"<br>
<br>
uint8_t convert_to_vid(uint16_t vddc)<br>
{<br>
@@ -545,17 +546,17 @@ int phm_irq_process(struct amdgpu_device *adev,<br>
uint32_t src_id = entry->src_id;<br>
<br>
if (client_id == AMDGPU_IH_CLIENTID_LEGACY) {<br>
- if (src_id == 230)<br>
+ if (src_id == VISLANDS30_IV_SRCID_CG_TSS_THERMAL_LOW_TO_HIGH)<br>
pr_warn("GPU over temperature range detected on PCIe %d:%d.%d!\n",<br>
PCI_BUS_NUM(adev->pdev->devfn),<br>
PCI_SLOT(adev->pdev->devfn),<br>
PCI_FUNC(adev->pdev->devfn));<br>
- else if (src_id == 231)<br>
+ else if (src_id == VISLANDS30_IV_SRCID_CG_TSS_THERMAL_HIGH_TO_LOW)<br>
pr_warn("GPU under temperature range detected on PCIe %d:%d.%d!\n",<br>
PCI_BUS_NUM(adev->pdev->devfn),<br>
PCI_SLOT(adev->pdev->devfn),<br>
PCI_FUNC(adev->pdev->devfn));<br>
- else if (src_id == 83)<br>
+ else if (src_id == VISLANDS30_IV_SRCID_GPIO_19)<br>
pr_warn("GPU Critical Temperature Fault detected on PCIe %d:%d.%d!\n",<br>
PCI_BUS_NUM(adev->pdev->devfn),<br>
PCI_SLOT(adev->pdev->devfn),<br>
-- <br>
2.13.6<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk172298" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
<div id="LPBorder_GT_15319699432060.6257980911014319" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;">
<table id="LPContainer_15319699432040.6574969579562752" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);" role="presentation" cellspacing="0">
<tbody>
<tr style="border-spacing: 0px;" valign="top">
<td id="TextCell_15319699432040.6050168821040637" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;" colspan="2">
<div id="LPRemovePreviewContainer_15319699432040.6903147049645878"></div>
<div id="LPTitle_15319699432040.7425574714543738" style="top: 0px; color: rgb(0, 120, 215); font-weight: 400; font-size: 21px; font-family: "wf_segoe-ui_light", "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;">
<a id="LPUrlAnchor_15319699432060.5932474573215077" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div>
<div id="LPMetadata_15319699432060.30198185270894895" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;">
lists.freedesktop.org</div>
<div id="LPDescription_15319699432060.056833642577140076" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;">
Subscribing to amd-gfx: Subscribe to amd-gfx by filling out the following form. Use of all freedesktop.org lists is subject to our Code of Conduct.</div>
</td>
</tr>
</tbody>
</table>
</div>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>