<div dir="ltr">Hi<div><br></div><div>I was hitting this</div><div><br></div><div>Feel free to add my tested by</div><div><br></div><div>Tested-by: Mike Lothian <<a href="mailto:mike@fireburn.co.uk">mike@fireburn.co.uk</a>></div><div><br></div><div>Cheers</div><div><br></div><div>Mike</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, 23 Jul 2018 at 17:50 Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2018-07-19 05:39 PM, Michel Dänzer wrote:<br>
> From: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com" target="_blank">michel.daenzer@amd.com</a>><br>
> <br>
> The warning turned out to be not so useful, as BO destruction tends to<br>
> be deferred to a workqueue.<br>
> <br>
> Also, we should be preventing any damage from this now, so not really<br>
> important anymore to fix code doing this.<br>
> <br>
> Signed-off-by: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com" target="_blank">michel.daenzer@amd.com</a>><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<br>
> index b12526ce1a9d..3010f0136de9 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c<br>
> @@ -89,7 +89,7 @@ static void amdgpu_ttm_bo_destroy(struct ttm_buffer_object *tbo)<br>
> struct amdgpu_device *adev = amdgpu_ttm_adev(tbo->bdev);<br>
> struct amdgpu_bo *bo = ttm_to_amdgpu_bo(tbo);<br>
> <br>
> - if (WARN_ON_ONCE(bo->pin_count > 0))<br>
> + if (bo->pin_count > 0)<br>
> amdgpu_bo_subtract_pin_size(bo);<br>
> <br>
> if (bo->kfd_bo)<br>
> <br>
<br>
Any feedback?<br>
<br>
<br>
-- <br>
Earthling Michel Dänzer | <a href="http://www.amd.com" rel="noreferrer" target="_blank">http://www.amd.com</a><br>
Libre software enthusiast | Mesa and X developer<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a href="mailto:amd-gfx@lists.freedesktop.org" target="_blank">amd-gfx@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</blockquote></div>