<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0"><span style="font-size:12pt;" id="divtagdefaultwrapper"></p>
<div style="margin-top:0;margin-bottom:0;">Series is:</div>
<div style="margin-top:0;margin-bottom:0;"><font size="2" color="black" face="sans-serif"><span style="font-size:11pt;">Reviewed-by: Rex Zhu<</span></font><a href="mailto:rezhu@amd.com" target="_blank" rel="noopener noreferrer" data-auth="NotApplicable" id="LPlnk933400" previewremoved="true"><font size="2" face="sans-serif"><span style="font-size:11pt;" id="LPlnk933400">rezhu@amd.com</span></font></a><font size="2" color="black" face="sans-serif"><span style="font-size:11pt;">>
</span></font><font size="2" color="black" face="sans-serif"><span style="font-size:11pt;"><br>
</span></font></div>
<div style="margin-top:0;margin-bottom:0;"><br>
</div>
<div style="margin-top:0;margin-bottom:0;"><br>
</div>
<div style="margin-top:0;margin-bottom:0;">Best Regards</div>
<div style="margin-top:0;margin-bottom:0;">Rex</div>
</span><br>
<p></p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> Quan, Evan<br>
<b>Sent:</b> Monday, July 23, 2018 2:38 PM<br>
<b>To:</b> Quan, Evan; amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Zhu, Rex<br>
<b>Subject:</b> RE: [PATCH 2/3] drm/amd/powerplay: correct the argument for PPSMC_MSG_SetUclkFastSwitch</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Ping ..<br>
<br>
> -----Original Message-----<br>
> From: Evan Quan <evan.quan@amd.com><br>
> Sent: Friday, July 20, 2018 10:35 AM<br>
> To: amd-gfx@lists.freedesktop.org<br>
> Cc: Zhu, Rex <Rex.Zhu@amd.com>; Quan, Evan <Evan.Quan@amd.com><br>
> Subject: [PATCH 2/3] drm/amd/powerplay: correct the argument for<br>
> PPSMC_MSG_SetUclkFastSwitch<br>
> <br>
> The argument was set wrongly. Fast/slow switch was asked when there is<br>
> actually a slow/fast switch needed.<br>
> <br>
> Change-Id: Ibcfdf741dea1700cc3796f84291606231e732f4b<br>
> Signed-off-by: Evan Quan <evan.quan@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 2 +-<br>
> drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c | 2 +-<br>
> 2 files changed, 2 insertions(+), 2 deletions(-)<br>
> <br>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> index bf7b8cfebe2b..002ed77a5268 100644<br>
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c<br>
> @@ -3705,7 +3705,7 @@ static void<br>
> vega10_notify_smc_display_change(struct pp_hwmgr *hwmgr, {<br>
> smum_send_msg_to_smc_with_parameter(hwmgr,<br>
> PPSMC_MSG_SetUclkFastSwitch,<br>
> - has_disp ? 0 : 1);<br>
> + has_disp ? 1 : 0);<br>
> }<br>
> <br>
> int vega10_display_clock_voltage_request(struct pp_hwmgr *hwmgr, diff --<br>
> git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br>
> b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br>
> index 4ed218dd8ba7..35f96dacb50a 100644<br>
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br>
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega12_hwmgr.c<br>
> @@ -1334,7 +1334,7 @@ static int vega12_notify_smc_display_change(struct<br>
> pp_hwmgr *hwmgr,<br>
> if (data->smu_features[GNLD_DPM_UCLK].enabled)<br>
> return smum_send_msg_to_smc_with_parameter(hwmgr,<br>
> PPSMC_MSG_SetUclkFastSwitch,<br>
> - has_disp ? 0 : 1);<br>
> + has_disp ? 1 : 0);<br>
> <br>
> return 0;<br>
> }<br>
> --<br>
> 2.18.0<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>