<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Series is <span>Reviewed-by: Evan Quan <evan.quan@amd.com></span></p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Rex Zhu <rex.zhu@amd.com><br> <b>Sent:</b> Wednesday, July 25, 2018 1:03:13 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Zhu, Rex<br> <b>Subject:</b> [PATCH 2/2] drm/amdgpu: fix a reversed condition</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">This test was reversed so it would end up leading to vddnb value<br> can't be read on APU.<br> <br> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br> index 15a1192..23fc1d3 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c<br> @@ -1185,7 +1185,7 @@ static ssize_t amdgpu_hwmon_show_vddnb(struct device *dev,<br> int r, size = sizeof(vddnb);<br> <br> /* only APUs have vddnb */<br> - if (adev->flags & AMD_IS_APU)<br> + if (!(adev->flags & AMD_IS_APU))<br> return -EINVAL;<br> <br> /* Can't get voltage when the card is off */<br> -- <br> 1.9.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </body> </html>