<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Yes, this is for amd-staging-drm-next and ultimately upstream.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Alex<br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Kuehling, Felix<br>
<b>Sent:</b> Tuesday, August 21, 2018 4:10:07 PM<br>
<b>To:</b> Quan, Evan; amd-gfx@lists.freedesktop.org; Russell, Kent<br>
<b>Cc:</b> Deucher, Alexander; Zhang, Hawking<br>
<b>Subject:</b> Re: [PATCH] drm/amdgpu: fix sdma doorbell range setting</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">[+Kent]<br>
<br>
Which branch is this for?<br>
<br>
amd-staging-drm-next doesn't have Shaoyun's other changes for changing<br>
the doorbell layout, so this change looks reasonable for<br>
amd-staging-drm-next.<br>
<br>
Kent, we should not merge this change into amd-kfd-staging, because it<br>
would break KFD's 8 SDMA queues per engine. I'm preparing upstreaming<br>
Vega20 changes KFD. That will include reverting this commit.<br>
<br>
Regards,<br>
Felix<br>
<br>
On 2018-08-21 04:21 AM, Evan Quan wrote:<br>
> Use the old doorbell range setting until the driver is<br>
> able to support more sdma queues.<br>
><br>
> Change-Id: I80fc067fc64878d3c7dc3d38bbe1c6c94bec397f<br>
> Signed-off-by: Evan Quan <evan.quan@amd.com><br>
> ---<br>
> drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c<br>
> index 89ea92075b6b..2e65447637c6 100644<br>
> --- a/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c<br>
> +++ b/drivers/gpu/drm/amd/amdgpu/nbio_v7_4.c<br>
> @@ -76,7 +76,7 @@ static void nbio_v7_4_sdma_doorbell_range(struct amdgpu_device *adev, int instan<br>
> <br>
> if (use_doorbell) {<br>
> doorbell_range = REG_SET_FIELD(doorbell_range, BIF_SDMA0_DOORBELL_RANGE, OFFSET, doorbell_index);<br>
> - doorbell_range = REG_SET_FIELD(doorbell_range, BIF_SDMA0_DOORBELL_RANGE, SIZE, 8);<br>
> + doorbell_range = REG_SET_FIELD(doorbell_range, BIF_SDMA0_DOORBELL_RANGE, SIZE, 2);<br>
> } else<br>
> doorbell_range = REG_SET_FIELD(doorbell_range, BIF_SDMA0_DOORBELL_RANGE, SIZE, 0);<br>
> <br>
<br>
</div>
</span></font></div>
</body>
</html>