<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<meta content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF">
<div dir="auto">Yes, that is actually desired.
<div dir="auto"><br>
</div>
<div dir="auto">We should not flush the system VM just because we do some clearing command submission.</div>
<div dir="auto"><br>
</div>
<div dir="auto">Christian.</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">Am 11.09.2018 15:54 schrieb "Grodzovsky, Andrey" <Andrey.Grodzovsky@amd.com>:<br type="attribution">
</div>
</div>
<div>By current code logic job->vm_pd_addr is never going to be set unless the job is created for user SC or for buffer copy in amdgpu_copy_buffer<br>
So in any other case we are going to skip VM flush. But amdgpu_vm_flush wants a flush to happen in case GPU reset just happend (amdgpu_vmid_had_gpu_reset is true)<br>
so we will be skipping that VM flush (as in my case with amdgpu_driver_open_kms->amdgpu_vm_init->amdgpu_vm_clear_bo right after GPU reset occured)<br>
Is it safe ?<br>
<br>
Andrey<br>
<br>
<div class="moz-cite-prefix">On 09/11/2018 07:46 AM, Christian König wrote:<br>
</div>
<blockquote type="cite">
<div class="moz-cite-prefix">It would probably be better to initialize job->vm_pd_addr with AMDGPU_BO_INVALID_OFFSET.<br>
<br>
And then just drop the vm flush alltogether when the vm_pd_addr isn't set to something sane.<br>
<br>
Thanks,<br>
Christian.<br>
<br>
Am 11.09.2018 um 00:52 schrieb Andrey Grodzovsky:<br>
</div>
<blockquote type="cite">Attached patch fixes SDMA TO after GPU reset, it's a regression caused by cbd5285 drm/amdgpu: move setting the GART addr into TTM.
<br>
<br>
But to me it looks safer just to revert the original patch all together since we never can predict for sure if VM flush will take place and so it's safer to just always assign job->vm_pd_addr.
<br>
<br>
Andrey <br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset> <br>
<pre>_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</div>
</body>
</html>