<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body bgcolor="white" lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> From: Christian König <ckoenig.leichtzumerken@gmail.com> Sent: Tuesday, September 11, 2018 2:40 PM To: Zhou, David(ChunMing) <David1.Zhou@amd.com>; Deng, Emily <Emily.Deng@amd.com>; Zhou, David(ChunMing) <David1.Zhou@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Fix the dead lock issue.<o:p></o:p> <o:p> </o:p> <div> That won't work correctly. The TTM BO is unreferenced in a couple of more places which we don't have control over. To make it even worse we actually can't take the reservation lock during GPU reset because the reservation object might already be destroyed when we remove the BO from the list. I will take a look at this myself today to find a solution which should work.<o:p></o:p> Ok, thanks very much.<o:p></o:p> <o:p> </o:p> Best wishes<o:p></o:p> Emily Deng<o:p></o:p> </div> <o:p> </o:p> <o:p> </o:p> Regards, Christian. Am 11.09.2018 um 07:41 schrieb zhoucm1:<o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> On 2018年09月11日 11:37, zhoucm1 wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> On 2018年09月11日 11:32, Deng, Emily wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> -----Original Message----- From: amd-gfx <a href="mailto:amd-gfx-bounces@lists.freedesktop.org"><amd-gfx-bounces@lists.freedesktop.org></a> On Behalf Of zhoucm1 Sent: Tuesday, September 11, 2018 11:28 AM To: Deng, Emily <a href="mailto:Emily.Deng@amd.com"><Emily.Deng@amd.com></a>; Zhou, David(ChunMing) <a href="mailto:David1.Zhou@amd.com"><David1.Zhou@amd.com></a>; <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] drm/amdgpu: Fix the dead lock issue. On 2018年09月11日 11:23, Deng, Emily wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> -----Original Message----- From: Zhou, David(ChunMing) Sent: Tuesday, September 11, 2018 11:03 AM To: Deng, Emily <a href="mailto:Emily.Deng@amd.com"><Emily.Deng@amd.com></a>; <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a> Subject: Re: [PATCH] drm/amdgpu: Fix the dead lock issue. On 2018年09月11日 10:51, Emily Deng wrote: <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> It will ramdomly have the dead lock issue when test TDR: 1. amdgpu_device_handle_vram_lost gets the lock shadow_list_lock 2. amdgpu_bo_create locked the bo's resv lock 3. amdgpu_bo_create_shadow is waiting for the shadow_list_lock 4. amdgpu_device_recover_vram_from_shadow is waiting for the bo's resv lock. v2: Make a local copy of the list Signed-off-by: Emily Deng <a href="mailto:Emily.Deng@amd.com"><Emily.Deng@amd.com></a> --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 21 <o:p></o:p> </blockquote> ++++++++++++++++++++- <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index 2a21267..8c81404 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c @@ -3105,6 +3105,9 @@ static int <o:p></o:p> </blockquote> amdgpu_device_handle_vram_lost(struct amdgpu_device *adev) <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> long r = 1; int i = 0; long tmo; + struct list_head local_shadow_list; + + INIT_LIST_HEAD(&local_shadow_list); if (amdgpu_sriov_runtime(adev)) tmo = msecs_to_jiffies(8000); @@ -3112,8 +3115,19 @@ static int <o:p></o:p> </blockquote> amdgpu_device_handle_vram_lost(struct amdgpu_device *adev) <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> tmo = msecs_to_jiffies(100); DRM_INFO("recover vram bo from shadow start\n"); + + mutex_lock(&adev->shadow_list_lock); + list_splice_init(&adev->shadow_list, &local_shadow_list); + mutex_unlock(&adev->shadow_list_lock); + + mutex_lock(&adev->shadow_list_lock); <o:p></o:p> </blockquote> local_shadow_list is a local variable, I think it doesn't need lock at all, no one change it. Otherwise looks good to me. <o:p></o:p> </blockquote> The bo->shadow_list which now is in local_shadow_list maybe destroy in case that it already in amdgpu_bo_destroy, then it will change <o:p></o:p> </blockquote> local_shadow_list, so need lock the shadow_list_lock. Ah, sorry for noise, I forget you don't reference these BOs. <o:p></o:p> </blockquote> Yes, I don't reference these Bos, as I found even reference these Bos, it still couldn't avoid the case that another process is already in amdgpu_bo_destroy. <o:p></o:p> </blockquote> ??? that shouldn't happen, the reference is belonged to list. But back to here, we don't need reference them. And since no shadow BO is added to local after splice, we'd better to use list_next_entry to iterate the local shadow list instead of list_for_each_entry_safe. Thanks, David Zhou <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Thanks, David Zhou <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Best wishes Emily Deng <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> Thanks, David Zhou <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> - list_for_each_entry_safe(bo, tmp, &adev->shadow_list, shadow_list) { + list_for_each_entry_safe(bo, tmp, &local_shadow_list, shadow_list) { <o:p></o:p> </blockquote> </blockquote> </blockquote> </blockquote> </blockquote> </blockquote> because shadow list doesn't take bo reference, we should give a amdgpu_bo_ref(bo) with attached patch before unlock. You can have a try. Thanks, David Zhou <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> + mutex_unlock(&adev->shadow_list_lock); + + if (!bo) + continue; + next = NULL; amdgpu_device_recover_vram_from_shadow(adev, ring, bo, <o:p></o:p> </blockquote> &next); <o:p></o:p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> if (fence) { @@ -3132,9 +3146,14 @@ static int amdgpu_device_handle_vram_lost(struct amdgpu_device *adev) dma_fence_put(fence); fence = next; + mutex_lock(&adev->shadow_list_lock); } mutex_unlock(&adev->shadow_list_lock); + mutex_lock(&adev->shadow_list_lock); + list_splice_init(&local_shadow_list, &adev->shadow_list); + mutex_unlock(&adev->shadow_list_lock); + if (fence) { r = dma_fence_wait_timeout(fence, false, tmo); if (r == 0) <o:p></o:p> </blockquote> </blockquote> </blockquote> _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <o:p></o:p> </blockquote> </blockquote> _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <o:p></o:p> </blockquote> <o:p></o:p> <pre>_______________________________________________<o:p></o:p></pre> <pre>amd-gfx mailing list<o:p></o:p></pre> <pre><a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><o:p></o:p></pre> <pre><a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></pre> </blockquote> <o:p> </o:p> </div> </body> </html>