<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;"> <p style="margin-top:0; margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> </p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Michel Dänzer <michel@daenzer.net><br> <b>Sent:</b> Thursday, September 13, 2018 5:47:29 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> [PATCH xf86-video-amdgpu] Bail from drmmode_cm_init if there's no CRTC</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="PlainText">From: Michel Dänzer <michel.daenzer@amd.com><br> <br> We would crash due to dereferencing the NULL mode_res->crtc pointer.<br> <br> Bugzilla: <a href="https://bugs.freedesktop.org/107913" id="LPlnk315283" class="OWAAutoLink" previewremoved="true"> https://bugs.freedesktop.org/107913</a><br> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com><br> ---<br> src/drmmode_display.c | 3 +++<br> 1 file changed, 3 insertions(+)<br> <br> diff --git a/src/drmmode_display.c b/src/drmmode_display.c<br> index 6ef6a98e2..cbda8ad35 100644<br> --- a/src/drmmode_display.c<br> +++ b/src/drmmode_display.c<br> @@ -3198,6 +3198,9 @@ static void drmmode_cm_init(int drm_fd, drmmode_ptr drmmode,<br> memset(drmmode->cm_prop_ids, 0, sizeof(drmmode->cm_prop_ids));<br> drmmode->gamma_lut_size = drmmode->degamma_lut_size = 0;<br> <br> + if (!mode_res->crtcs)<br> + return;<br> +<br> /* AMD hardware has color management support on all pipes. It is<br> * therefore sufficient to only check the first CRTC.<br> */<br> -- <br> 2.19.0.rc2<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk971804" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </body> </html>