<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br> </p> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Sent:</b> Friday, September 14, 2018 6:57 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> [PATCH 1/2] drm/amdgpu: fix mask in GART location calculation</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">We need to mask the lower bits not the upper one.<br> <br> Fixes: ec210e3226dc0 drm/amdgpu: put GART away from VRAM v2<br> <br> Signed-off-by: Christian König <christian.koenig@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c<br> index ae4467113240..9a5b252784a1 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c<br> @@ -166,7 +166,7 @@ void amdgpu_gmc_gart_location(struct amdgpu_device *adev, struct amdgpu_gmc *mc)<br> else<br> mc->gart_start = mc->mc_mask - mc->gart_size + 1;<br> <br> - mc->gart_start &= four_gb - 1;<br> + mc->gart_start &= ~(four_gb - 1);<br> mc->gart_end = mc->gart_start + mc->gart_size - 1;<br> dev_info(adev->dev, "GART: %lluM 0x%016llX - 0x%016llX\n",<br> mc->gart_size >> 20, mc->gart_start, mc->gart_end);<br> -- <br> 2.14.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk501667" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </div> </body> </html>