<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">On Linux, the clocks are already set by the time that function call is reached. amdgpu_pm_compute clocks resets the clocks to their default value.</p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Zhu, Rex<br> <b>Sent:</b> September 17, 2018 4:12:33 AM<br> <b>To:</b> Deucher, Alexander; Wentland, Harry; Francis, David<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> RE: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes</font> <div> </div> </div> <meta content="text/html; charset=us-ascii"> <meta name="x_Generator" content="Microsoft Word 15 (filtered medium)"> <style>  </style> <div lang="EN-US" link="blue" vlink="purple"> <div class="x_WordSection1"> <p class="x_MsoNormal">+Harry and David.</p> <p class="x_MsoNormal"> </p> <p class="x_MsoNormal">Best Regards</p> <p class="x_MsoNormal">Rex</p> <p class="x_MsoNormal"> </p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #E1E1E1 1.0pt; padding:3.0pt 0in 0in 0in"> <p class="x_MsoNormal"><b>From:</b> Deucher, Alexander <br> <b>Sent:</b> Friday, September 14, 2018 9:40 PM<br> <b>To:</b> Zhu, Rex <Rex.Zhu@amd.com>; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes</p> </div> </div> <p class="x_MsoNormal"> </p> <div id="x_divtagdefaultwrapper"> <p><span style="font-size:12.0pt; color:black">Acked-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>></span></p> </div> <div class="x_MsoNormal" align="center" style="text-align:center"> <hr size="3" width="98%" align="center"> </div> <div id="x_divRplyFwdMsg"> <p class="x_MsoNormal"><b><span style="color:black">From:</span></b><span style="color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Rex Zhu <<a href="mailto:Rex.Zhu@amd.com">Rex.Zhu@amd.com</a>><br> <b>Sent:</b> Friday, September 14, 2018 1:57:07 AM<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Zhu, Rex<br> <b>Subject:</b> [PATCH] drm/amd/dc: Trigger set power state task when display configuration changes</span> </p> <div> <p class="x_MsoNormal"> </p> </div> </div> <div> <div> <p class="x_MsoNormal">Revert "drm/amd/display: Remove call to amdgpu_pm_compute_clocks"<br> <br> This reverts commit dcd473770e86517543691bdb227103d6c781cd0a.<br> <br> when display configuration changes, dc need to update the changes<br> to powerplay, also need to trigger a power state task.<br> amdgpu_pm_compute_clocks is the interface to set power state task<br> either dpm enabled or powerplay enabled<br> <br> Signed-off-by: Rex Zhu <<a href="mailto:Rex.Zhu@amd.com">Rex.Zhu@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c | 2 ++<br> 1 file changed, 2 insertions(+)<br> <br> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c<br> index 6d16b4a..0fab64a 100644<br> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c<br> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_pp_smu.c<br> @@ -105,6 +105,8 @@ bool dm_pp_apply_display_requirements(<br> adev->powerplay.pp_funcs->display_configuration_change(<br> adev->powerplay.pp_handle,<br> &adev->pm.pm_display_cfg);<br> +<br> + amdgpu_pm_compute_clocks(adev);<br> }<br> <br> return true;<br> -- <br> 1.9.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></p> </div> </div> </div> </div> </div> </body> </html>