<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Ping</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Alex and Christian,</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Could you give a review on this updated patch?<br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri,Arial,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;">
<p>Thanks & Best Regards!</p>
<p><br>
</p>
<p>James Zhu<br>
</p>
</div>
</div>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> James Zhu <jzhums@gmail.com><br>
<b>Sent:</b> Thursday, September 13, 2018 4:55 PM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Zhu, James<br>
<b>Subject:</b> [PATCH v2] drm/amdgpu:No action when VCN PG state is unchanged</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">When VCN PG state is unchanged, it is unnecessary to reset power<br>
gate state<br>
<br>
Signed-off-by: James Zhu <James.Zhu@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h | 1 +<br>
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 12 ++++++++++--<br>
2 files changed, 11 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h<br>
index 0b0b863..d2219ab 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.h<br>
@@ -69,6 +69,7 @@ struct amdgpu_vcn {<br>
struct amdgpu_ring ring_jpeg;<br>
struct amdgpu_irq_src irq;<br>
unsigned num_enc_rings;<br>
+ enum amd_powergating_state cur_state;<br>
};<br>
<br>
int amdgpu_vcn_sw_init(struct amdgpu_device *adev);<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c<br>
index 2664bb2..2cde0b4 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c<br>
@@ -1633,12 +1633,20 @@ static int vcn_v1_0_set_powergating_state(void *handle,<br>
* revisit this when there is a cleaner line between<br>
* the smc and the hw blocks<br>
*/<br>
+ int ret;<br>
struct amdgpu_device *adev = (struct amdgpu_device *)handle;<br>
<br>
+ if(state == adev->vcn.cur_state)<br>
+ return 0;<br>
+<br>
if (state == AMD_PG_STATE_GATE)<br>
- return vcn_v1_0_stop(adev);<br>
+ ret = vcn_v1_0_stop(adev);<br>
else<br>
- return vcn_v1_0_start(adev);<br>
+ ret = vcn_v1_0_start(adev);<br>
+<br>
+ if(!ret)<br>
+ adev->vcn.cur_state = state;<br>
+ return ret;<br>
}<br>
<br>
static const struct amd_ip_funcs vcn_v1_0_ip_funcs = {<br>
-- <br>
2.7.4<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>