<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>P.S I pushed it.</p>
<p><br>
</p>
<p>Thanks,</p>
<p>Andrey<br>
</p>
<br>
<div class="moz-cite-prefix">On 09/24/2018 11:13 AM, Andrey
Grodzovsky wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4ca8e57b-6927-e6a0-b063-9dc5a4d26952@amd.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<p>Reviewed-and-Tested-by: Andrey Grodzovsky <a
class="moz-txt-link-rfc2396E"
href="mailto:andrey.grodzovsky@amd.com" moz-do-not-send="true"><andrey.grodzovsky@amd.com></a><br>
</p>
<p><br>
</p>
<p>Andrey</p>
<p><br>
</p>
<div class="moz-cite-prefix">On 09/24/2018 10:31 AM, Deucher,
Alexander wrote:<br>
</div>
<blockquote type="cite"
cite="mid:BN6PR12MB18097AA77D7E8948DE462823F7170@BN6PR12MB1809.namprd12.prod.outlook.com">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
<div id="divtagdefaultwrapper"
style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;"
dir="ltr">
<p style="margin-top:0;margin-bottom:0">Acked-by: Alex Deucher
<a class="moz-txt-link-rfc2396E"
href="mailto:alexander.deucher@amd.com"
moz-do-not-send="true"><alexander.deucher@amd.com></a><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt"
face="Calibri, sans-serif" color="#000000"><b>From:</b>
amd-gfx <a class="moz-txt-link-rfc2396E"
href="mailto:amd-gfx-bounces@lists.freedesktop.org"
moz-do-not-send="true"><amd-gfx-bounces@lists.freedesktop.org></a>
on behalf of Christian König <a
class="moz-txt-link-rfc2396E"
href="mailto:ckoenig.leichtzumerken@gmail.com"
moz-do-not-send="true"><ckoenig.leichtzumerken@gmail.com></a><br>
<b>Sent:</b> Monday, September 24, 2018 8:10:22 AM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated"
href="mailto:amd-gfx@lists.freedesktop.org"
moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a><br>
<b>Subject:</b> [PATCH] drm/amdgpu: Deactivate SW interrupt
fallback in amdgpu_fence_process v2</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span
style="font-size:11pt;">
<div class="PlainText">From: Andrey Grodzovsky <a
class="moz-txt-link-rfc2396E"
href="mailto:andrey.grodzovsky@amd.com"
moz-do-not-send="true"><andrey.grodzovsky@amd.com></a><br>
<br>
Deactivate SW interrupt fallback when all emited fences
are completed.<br>
Also switch interrupt SW fallback message from INFO to
WARN.<br>
<br>
v2: shorten the warnign message a bit and only
re-activate the timer during<br>
processing if it was already activated before.<br>
<br>
Signed-off-by: Andrey Grodzovsky <a
class="moz-txt-link-rfc2396E"
href="mailto:andrey.grodzovsky@amd.com"
moz-do-not-send="true"><andrey.grodzovsky@amd.com></a><br>
Suggested-by: Christian Konig <a
class="moz-txt-link-rfc2396E"
href="mailto:Christian.Koenig@amd.com"
moz-do-not-send="true"><Christian.Koenig@amd.com></a><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 5 +++--<br>
1 file changed, 3 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
index 1ae25835cad1..4e6e9c9654dd 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
@@ -229,7 +229,8 @@ void amdgpu_fence_process(struct
amdgpu_ring *ring)<br>
<br>
} while (atomic_cmpxchg(&drv->last_seq,
last_seq, seq) != last_seq);<br>
<br>
- if (seq != ring->fence_drv.sync_seq)<br>
+ if
(del_timer(&ring->fence_drv.fallback_timer)
&&<br>
+ seq != ring->fence_drv.sync_seq)<br>
amdgpu_fence_schedule_fallback(ring);<br>
<br>
if (unlikely(seq == last_seq))<br>
@@ -274,7 +275,7 @@ static void
amdgpu_fence_fallback(struct timer_list *t)<br>
struct amdgpu_ring *ring = from_timer(ring, t,<br>
fence_drv.fallback_timer);<br>
<br>
- DRM_INFO("Fallback to SW interrupt on ring %s
due to HW interrupt time out", ring->name);<br>
+ DRM_WARN("Fence fallback timer expired on ring
%s\n", ring->name);<br>
amdgpu_fence_process(ring);<br>
}<br>
<br>
-- <br>
2.14.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
<a class="moz-txt-link-abbreviated"
href="mailto:amd-gfx@lists.freedesktop.org"
moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a><br>
<a
href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx"
moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org" moz-do-not-send="true">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" moz-do-not-send="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
amd-gfx mailing list
<a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a>
<a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a>
</pre>
</blockquote>
<br>
</body>
</html>