<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Ok. I will remove the code.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Best Regards</p> <p style="margin-top:0;margin-bottom:0">Rex<br> </p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" color="#000000" face="Calibri, sans-serif"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Sent:</b> Wednesday, September 26, 2018 8:45 PM<br> <b>To:</b> Zhu, Rex; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: Fix copy error in uvd_v6/7_0.c</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Am 26.09.2018 um 14:41 schrieb Rex Zhu:<br> > Signed-off-by: Rex Zhu <Rex.Zhu@amd.com><br> <br> Actually that code can just be removed because uvd_*_enc_get_destroy_msg <br> is only called with direct=true.<br> <br> Christian.<br> <br> > ---<br> > drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 2 +-<br> > drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 +-<br> > 2 files changed, 2 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c<br> > index 8ef4a53..2ceab76 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c<br> > @@ -313,7 +313,7 @@ static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,<br> > if (direct)<br> > r = amdgpu_job_submit_direct(job, ring, &f);<br> > else<br> > - r = amdgpu_job_submit(job, &ring->adev->vce.entity,<br> > + r = amdgpu_job_submit(job, &ring->adev->uvd.entity,<br> > AMDGPU_FENCE_OWNER_UNDEFINED, &f);<br> > if (r)<br> > goto err;<br> > diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c<br> > index a289f6a..31a9665 100644<br> > --- a/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c<br> > +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c<br> > @@ -320,7 +320,7 @@ int uvd_v7_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,<br> > if (direct)<br> > r = amdgpu_job_submit_direct(job, ring, &f);<br> > else<br> > - r = amdgpu_job_submit(job, &ring->adev->vce.entity,<br> > + r = amdgpu_job_submit(job, &ring->adev->uvd.entity,<br> > AMDGPU_FENCE_OWNER_UNDEFINED, &f);<br> > if (r)<br> > goto err;<br> <br> </div> </span></font></div> </div> </div> </body> </html>