<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Acked-by: Alex Deucher <alexander.deucher@amd.com><br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Kent Russell <kent.russell@amd.com><br> <b>Sent:</b> Wednesday, September 26, 2018 9:41:52 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Russell, Kent; Liu, Shaoyun<br> <b>Subject:</b> [PATCH] drm/amdkfd: Remove the requirement for atomic Ops on vg20</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">From: Shaoyun Liu <Shaoyun.Liu@amd.com><br> <br> Firmware have the workaround to replace the atomic Ops with read-modify-write on CP side.<br> User should not expect atomic Ops on system memory works normally if system didn't not<br> support it.<br> <br> Change-Id: I89395b099fe0931b9b3627651b512dde3149fadd<br> Signed-off-by: Shaoyun Liu <Shaoyun.Liu@amd.com><br> Signed-off-by: Kent Russell <kent.russell@amd.com><br> ---<br> drivers/gpu/drm/amd/amdkfd/kfd_device.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device.c b/drivers/gpu/drm/amd/amdkfd/kfd_device.c<br> index b0c2afb..b505bf3 100644<br> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device.c<br> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device.c<br> @@ -263,7 +263,7 @@ static const struct kfd_device_info vega20_device_info = {<br> .mqd_size_aligned = MQD_SIZE_ALIGNED,<br> .supports_cwsr = true,<br> .needs_iommu_device = false,<br> - .needs_pci_atomics = true,<br> + .needs_pci_atomics = false,<br> .num_sdma_engines = 2,<br> .num_sdma_queues_per_engine = 8,<br> };<br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </body> </html>