<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Satyajit Sahu <satyajit.sahu@amd.com><br>
<b>Sent:</b> Wednesday, September 26, 2018 4:34:39 AM<br>
<b>To:</b> Deucher, Alexander; amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Sahu, Satyajit; Agrawal, Akshu<br>
<b>Subject:</b> [PATCH] drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">From: Akshu Agrawal <akshu.agrawal@amd.com><br>
<br>
We observe black lines (underflow) on display when playing a<br>
4K video with UVD. On Disabling Low memory P state this issue is<br>
not seen.<br>
Multiple runs of power measurement shows no imapct.<br>
<br>
Change-Id: I6171ced550ee244e6b9a961fb50247d12f4168a0<br>
Signed-off-by: Akshu Agrawal <akshu.agrawal@amd.com><br>
Signed-off-by: Satyajit Sahu <satyajit.sahu@amd.com><br>
Acked-by: Alex Deucher <alexander.deucher@amd.com><br>
---<br>
drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c | 5 ++++-<br>
1 file changed, 4 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c<br>
index b863704..86b6a43 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c<br>
@@ -1227,14 +1227,17 @@ static int smu8_dpm_force_dpm_level(struct pp_hwmgr *hwmgr,<br>
<br>
static int smu8_dpm_powerdown_uvd(struct pp_hwmgr *hwmgr)<br>
{<br>
- if (PP_CAP(PHM_PlatformCaps_UVDPowerGating))<br>
+ if (PP_CAP(PHM_PlatformCaps_UVDPowerGating)) {<br>
+ smu8_nbdpm_pstate_enable_disable(hwmgr, true, true);<br>
return smum_send_msg_to_smc(hwmgr, PPSMC_MSG_UVDPowerOFF);<br>
+ }<br>
return 0;<br>
}<br>
<br>
static int smu8_dpm_powerup_uvd(struct pp_hwmgr *hwmgr)<br>
{<br>
if (PP_CAP(PHM_PlatformCaps_UVDPowerGating)) {<br>
+ smu8_nbdpm_pstate_enable_disable(hwmgr, false, true);<br>
return smum_send_msg_to_smc_with_parameter(<br>
hwmgr,<br>
PPSMC_MSG_UVDPowerON,<br>
-- <br>
1.9.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>