<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <div id="divtagdefaultwrapper" dir="ltr" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;"> <p style="margin-top:0; margin-bottom:0">Series is:</p> <p style="margin-top:0; margin-bottom:0">Acked-by: Alex Deucher <alexander.deucher@amd.com><br> </p> </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Roman.Li@amd.com <Roman.Li@amd.com><br> <b>Sent:</b> Tuesday, October 9, 2018 1:50:09 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Li, Sun peng (Leo); Wu, Hersen; Wentland, Harry; Li, Roman<br> <b>Subject:</b> [PATCH 1/2] drm/amd/display: Fix warning storm on Raven2</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="PlainText">From: Roman Li <Roman.Li@amd.com><br> <br> [Why]<br> Wrong index for pstate debug test register<br> <br> [How]<br> Add correct index value for dcn1_01 in hubbub1_construct()<br> <br> Signed-off-by: Hersen Wu <hersenxs.wu@amd.com><br> Signed-off-by: Roman Li <Roman.Li@amd.com><br> ---<br> .../gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c | 43 +++++++++++++++++++++-<br> 1 file changed, 41 insertions(+), 2 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c<br> index 69345ce6..4254e7e 100644<br> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c<br> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hubbub.c<br> @@ -133,7 +133,43 @@ bool hubbub1_verify_allow_pstate_change_high(<br> forced_pstate_allow = false;<br> }<br> <br> - /* RV1:<br> + /* RV2:<br> + * dchubbubdebugind, at: 0xB<br> + * description<br> + * 0: Pipe0 Plane0 Allow Pstate Change<br> + * 1: Pipe0 Plane1 Allow Pstate Change<br> + * 2: Pipe0 Cursor0 Allow Pstate Change<br> + * 3: Pipe0 Cursor1 Allow Pstate Change<br> + * 4: Pipe1 Plane0 Allow Pstate Change<br> + * 5: Pipe1 Plane1 Allow Pstate Change<br> + * 6: Pipe1 Cursor0 Allow Pstate Change<br> + * 7: Pipe1 Cursor1 Allow Pstate Change<br> + * 8: Pipe2 Plane0 Allow Pstate Change<br> + * 9: Pipe2 Plane1 Allow Pstate Change<br> + * 10: Pipe2 Cursor0 Allow Pstate Change<br> + * 11: Pipe2 Cursor1 Allow Pstate Change<br> + * 12: Pipe3 Plane0 Allow Pstate Change<br> + * 13: Pipe3 Plane1 Allow Pstate Change<br> + * 14: Pipe3 Cursor0 Allow Pstate Change<br> + * 15: Pipe3 Cursor1 Allow Pstate Change<br> + * 16: Pipe4 Plane0 Allow Pstate Change<br> + * 17: Pipe4 Plane1 Allow Pstate Change<br> + * 18: Pipe4 Cursor0 Allow Pstate Change<br> + * 19: Pipe4 Cursor1 Allow Pstate Change<br> + * 20: Pipe5 Plane0 Allow Pstate Change<br> + * 21: Pipe5 Plane1 Allow Pstate Change<br> + * 22: Pipe5 Cursor0 Allow Pstate Change<br> + * 23: Pipe5 Cursor1 Allow Pstate Change<br> + * 24: Pipe6 Plane0 Allow Pstate Change<br> + * 25: Pipe6 Plane1 Allow Pstate Change<br> + * 26: Pipe6 Cursor0 Allow Pstate Change<br> + * 27: Pipe6 Cursor1 Allow Pstate Change<br> + * 28: WB0 Allow Pstate Change<br> + * 29: WB1 Allow Pstate Change<br> + * 30: Arbiter's allow_pstate_change<br> + * 31: SOC pstate change request"<br> + *<br> + * RV1:<br> * dchubbubdebugind, at: 0x7<br> * description "3-0: Pipe0 cursor0 QOS<br> * 7-4: Pipe1 cursor0 QOS<br> @@ -157,7 +193,6 @@ bool hubbub1_verify_allow_pstate_change_high(<br> * 31: SOC pstate change request<br> */<br> <br> -<br> REG_WRITE(DCHUBBUB_TEST_DEBUG_INDEX, hubbub->debug_test_index_pstate);<br> <br> for (i = 0; i < pstate_wait_timeout_us; i++) {<br> @@ -819,5 +854,9 @@ void hubbub1_construct(struct hubbub *hubbub,<br> hubbub->masks = hubbub_mask;<br> <br> hubbub->debug_test_index_pstate = 0x7;<br> +#if defined(CONFIG_DRM_AMD_DC_DCN1_01)<br> + if (ctx->dce_version == DCN_VERSION_1_01)<br> + hubbub->debug_test_index_pstate = 0xB;<br> +#endif<br> }<br> <br> -- <br> 2.7.4<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk445418" class="OWAAutoLink" previewremoved="true">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15391075668560.6223877911093239" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15391075668520.6619941898908696" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);" role="presentation" cellspacing="0"> <tbody> <tr style="border-spacing: 0px;" valign="top"> <td id="TextCell_15391075668540.14967359666528068" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;" colspan="2"> <div id="LPRemovePreviewContainer_15391075668540.6907574272253448"></div> <div id="LPTitle_15391075668540.6597142408214279" style="top: 0px; color: rgb(0, 120, 215); font-weight: 400; font-size: 21px; font-family: "wf_segoe-ui_light", "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15391075668540.7588781973848282" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15391075668550.4384515405369218" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15391075668550.09770762632513252" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives.. Using amd-gfx: To post a message to all the list members, send email to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your existing subscription, in the sections below.</div> </td> </tr> </tbody> </table> </div> <br> </div> </span></font></div> </div> </body> </html>