<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">I think it's useful to keep around for bringup and early in the asic lifecycle.</p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Alex<br> </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Zhu, Rex<br> <b>Sent:</b> Tuesday, October 9, 2018 11:39:49 PM<br> <b>To:</b> Deucher, Alexander; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg</font> <div> </div> </div> <meta content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:#000000; font-family:Calibri,Helvetica,sans-serif"> <p style="margin-top:0; margin-bottom:0">Ok.</p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0">BTW, Maybe we can remove the module parameter <span>amdgpu_fw_load_type suppor </span>.<br> </p> <p style="margin-top:0; margin-bottom:0">It is only used for bring up/debug.</p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0">Best Regards</p> <p style="margin-top:0; margin-bottom:0">Rex<br> </p> <p style="margin-top:0; margin-bottom:0"><br> </p> <br> <div style="color:rgb(0,0,0)"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br> <b>Sent:</b> Wednesday, October 10, 2018 3:31 AM<br> <b>To:</b> Zhu, Rex; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg</font> <div> </div> </div> <meta content="text/html; charset=iso-8859-1"> <div dir="ltr"> <div id="x_x_divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols"> <p style="margin-top:0; margin-bottom:0">Maybe just drop the warning altogether? We only support SMU loading on VI at this point. Otherwise, we'll need to update this if we ever add a new fw loading type.<br> </p> <p style="margin-top:0; margin-bottom:0"><br> </p> <p style="margin-top:0; margin-bottom:0">Alex<br> </p> <div style="color:rgb(0,0,0)"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_x_divRplyFwdMsg" dir="ltr"><font color="#000000" face="Calibri, sans-serif" style="font-size:11pt"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Rex Zhu <Rex.Zhu@amd.com><br> <b>Sent:</b> Tuesday, October 9, 2018 11:36 AM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Zhu, Rex<br> <b>Subject:</b> [PATCH v2 4/5] drm/amdgpu: Fix unnecessary warning in dmesg</font> <div> </div> </div> <div class="x_x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_x_PlainText">Fix the warning message:<br> "-1 is not supported on VI"<br> the -1 is the default fw load type, mean auto.<br> <br> v2: fix typo<br> <br> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com><br> ---<br> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c<br> index 971549f..01d794d 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c<br> @@ -297,7 +297,7 @@ enum amdgpu_firmware_load_type<br> case CHIP_POLARIS11:<br> case CHIP_POLARIS12:<br> case CHIP_VEGAM:<br> - if (load_type != AMDGPU_FW_LOAD_SMU)<br> + if (load_type == AMDGPU_FW_LOAD_DIRECT || load_type == AMDGPU_FW_LOAD_PSP)<br> pr_warning("%d is not supported on VI\n", load_type);<br> return AMDGPU_FW_LOAD_SMU;<br> case CHIP_VEGA10:<br> -- <br> 1.9.1<br> <br> _______________________________________________<br> amd-gfx mailing list<br> amd-gfx@lists.freedesktop.org<br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk268037" class="x_x_OWAAutoLink">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> </div> </span></font></div> </div> </div> </div> </div> </div> </div> </body> </html>