<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); font-family: Calibri, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">There are two sets of power management code in amdgpu, the older dpm code which was ported from radeon, and the newer powerplay code which was rewritten to align closer with the power management code for other OSes and the hw teams. The "powerplay" code has more features than the older dpm code, but at a fundamental level, they are pretty much the same. Both use the same SMU interfaces to support dynamic clock switching. SI is a bit tricky because it uses and older version of the SMU and an older power management design so it doesn't really match cleanly with the current APIs in the "powerplay" code. <br> </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <p style="margin-top:0;margin-bottom:0">Alex<br> </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font style="font-size:11pt" face="Calibri, sans-serif" color="#000000"><b>From:</b> sylvain.bertrand@gmail.com <sylvain.bertrand@gmail.com><br> <b>Sent:</b> Monday, October 15, 2018 8:45 AM<br> <b>To:</b> Mauro Rossi<br> <b>Cc:</b> amd-gfx@lists.freedesktop.org; Wentland, Harry; Deucher, Alexander; Mike Lothian<br> <b>Subject:</b> Re: [RFC] drm/amd/display: add SI support to AMD DC</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">On Mon, Oct 15, 2018 at 07:28:57AM +0200, Mauro Rossi wrote:<br> > dpm for SI is available, while powerplay for SI is not, but<br> > display/amdgpu_dm uses some powerplay calls, where get_static_clock<br> > functions not available and the *ERROR* DM_PPLIB is due to missing handling<br> > in powerplay<br> <br> I though powerplay was just more power states for the dpm state machines to<br> play with. I recall parsing ATOMBIOS pplay tables for records of (voltages/clocks<br> frequencies).<br> <br> Maybe the future is to trust the OS kernel and perform all "low speed" 3D asic<br> functions there and keep only high speed 3D operations in the asic.<br> <br> -- <br> Sylvain<br> </div> </span></font></div> </div> </div> </body> </html>