<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Fully agreed. Will redesign this. </p> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Christian König <ckoenig.leichtzumerken@gmail.com><br> <b>Sent:</b> October 13, 2018 1:40:24 PM<br> <b>To:</b> Michel Dänzer; Lakha, Bhawanpreet<br> <b>Cc:</b> Francis, David; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> Re: [PATCH 17/26] drm/amd/display: implement PERF_TRACE on Linux</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">Am 12.10.2018 um 18:56 schrieb Michel Dänzer:<br> > On 2018-10-11 12:09 a.m., Bhawanpreet Lakha wrote:<br> >> From: David Francis <David.Francis@amd.com><br> >><br> >> [Why]<br> >> A quick-and-dirty way of getting performance data for the amdgpu<br> >> driver would make performance improvements easier<br> >><br> >> [How]<br> >> The PERF_TRACE functionality is a tic-toc style debug method.<br> >> Put PERF_TRACE calls on either side of the code you want to test.<br> >> PERF_TRACE requires access to struct dc_context. PERF_TRACE()<br> >> will pick up the CTX macro, and PERF_TRACE_CTX(struct dc_context)<br> >> allows you to pass the context explicitly.<br> >><br> >> The last 20 results can be read through the debugfs entry<br> >> amdgpu_perf_trace. Each result contains the time in ns and<br> >> number of GPU read/writes since the result before it.<br> >><br> >> In my experimentation, each PERF_TRACE() call uses at most 700ns<br> > Should this use the Linux tracing infrastructure?<br> <br> Yeah, agree that looks like reimplementing the tracing infrastructure to <br> me as well.<br> <br> Christian.<br> </div> </span></font></div> </body> </html>