<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=gb2312"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> Sure<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm"> From: Zhu, Rex Sent: 2018年10月24日 16:37 To: Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 3/3] drm/amd/powerplay: support hwmon max/min fan speed setting on Vega20<o:p></o:p> </div> </div> <o:p> </o:p> <div id="divtagdefaultwrapper"> - percent = current_rpm * 100 / pp_table->FanMaximumRpm; + percent = (current_rpm * 100) / + hwmgr->thermal_controller.fanInfo.ulMaxRPM;<o:p></o:p> <o:p> </o:p> Better check hwmgr->thermal_controller.fanInfo.ulMaxRPM not equal to 0.<o:p></o:p> <o:p> </o:p> Best Regards<o:p></o:p> Rex<o:p></o:p> <div> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="98%" align="center"> </div> <div id="divRplyFwdMsg"> From: amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Evan Quan <<a href="mailto:evan.quan@amd.com">evan.quan@amd.com</a>> Sent: Wednesday, October 24, 2018 4:11 PM To: <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> Cc: Quan, Evan Subject: [PATCH 3/3] drm/amd/powerplay: support hwmon max/min fan speed setting on Vega20 <o:p></o:p> <div> <o:p></o:p> </div> </div> <div> <div> Added support for hwmon max/min fan speed setting on Vega20. Change-Id: Ieab42c744d6c54f8b85a71be80f7c6832ae7352b Signed-off-by: Evan Quan <<a href="mailto:evan.quan@amd.com">evan.quan@amd.com</a>> --- .../drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 4 ++ .../drm/amd/powerplay/hwmgr/vega20_thermal.c | 56 ++++++++++++++++++- .../drm/amd/powerplay/hwmgr/vega20_thermal.h | 4 ++ 3 files changed, 62 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c index 57143d51e3ee..2513e6be3219 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c @@ -3539,6 +3539,10 @@ static const struct pp_hwmgr_func vega20_hwmgr_funcs = { vega20_get_fan_control_mode, .set_fan_control_mode = vega20_set_fan_control_mode, + .set_fan_speed_max_rpm = + vega20_fan_ctrl_set_fan_speed_max_rpm, + .set_fan_speed_min_rpm = + vega20_fan_ctrl_set_fan_speed_min_rpm, /* smu memory related */ .notify_cac_buffer_info = vega20_notify_cac_buffer_info, diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.c index ede54e87e287..da9fd2168dcb 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.c @@ -118,7 +118,6 @@ int vega20_fan_ctrl_get_fan_speed_percent(struct pp_hwmgr *hwmgr, uint32_t *speed) { struct vega20_hwmgr *data = (struct vega20_hwmgr *)(hwmgr->backend); - PPTable_t *pp_table = &(data->smc_state_table.pp_table); uint32_t current_rpm, percent = 0; int ret = 0; @@ -126,7 +125,8 @@ int vega20_fan_ctrl_get_fan_speed_percent(struct pp_hwmgr *hwmgr, if (ret) return ret; - percent = current_rpm * 100 / pp_table->FanMaximumRpm; + percent = (current_rpm * 100) / + hwmgr->thermal_controller.fanInfo.ulMaxRPM; *speed = percent > 100 ? 100 : percent; @@ -208,6 +208,58 @@ int vega20_fan_ctrl_set_fan_speed_rpm(struct pp_hwmgr *hwmgr, uint32_t speed) return vega20_fan_ctrl_set_static_mode(hwmgr, FDO_PWM_MODE_STATIC_RPM); } +int vega20_fan_ctrl_set_fan_speed_max_rpm(struct pp_hwmgr *hwmgr, uint32_t speed) +{ + struct vega20_hwmgr *data = (struct vega20_hwmgr *)(hwmgr->backend); + struct vega20_od8_settings *od8_settings = &(data->od8_settings); + int ret = 0; + + if ((od8_settings->overdrive8_capabilities & OD8_ACOUSTIC_LIMIT_SCLK) && + (speed > od8_settings->od8_settings_array[OD8_SETTING_FAN_ACOUSTIC_LIMIT].max_value || + speed < od8_settings->od8_settings_array[OD8_SETTING_FAN_ACOUSTIC_LIMIT].min_value)) + return -EINVAL; + + ret = smum_send_msg_to_smc_with_parameter(hwmgr, + PPSMC_MSG_SetFanMaxRpm, + speed); + PP_ASSERT_WITH_CODE(!ret, + "Set FanMaxRpm Failed!", + return ret); + + hwmgr->thermal_controller.fanInfo.ulMinRPM = + (speed * hwmgr->thermal_controller.fanInfo.ulMinPWM) / 255; + + return ret; +} + +int vega20_fan_ctrl_set_fan_speed_min_rpm(struct pp_hwmgr *hwmgr, uint32_t speed) +{ + struct vega20_hwmgr *data = (struct vega20_hwmgr *)(hwmgr->backend); + struct vega20_od8_settings *od8_settings = &(data->od8_settings); + int ret = 0; + uint32_t pwm = 0; + + if ((od8_settings->overdrive8_capabilities & OD8_FAN_SPEED_MIN) && + (speed > od8_settings->od8_settings_array[OD8_FAN_SPEED_MIN].max_value || + speed < od8_settings->od8_settings_array[OD8_FAN_SPEED_MIN].min_value)) + return -EINVAL; + + if (speed > hwmgr->thermal_controller.fanInfo.ulMaxRPM) + return -EINVAL; + + pwm = (speed * 255) / hwmgr->thermal_controller.fanInfo.ulMaxRPM; + ret = smum_send_msg_to_smc_with_parameter(hwmgr, + PPSMC_MSG_SetFanMinPwm, + pwm); + PP_ASSERT_WITH_CODE(!ret, + "Set FanMinPwm Failed!", + return ret); + + hwmgr->thermal_controller.fanInfo.ulMinPWM = pwm; + + return ret; +} + /** * Reads the remote temperature from the SIslands thermal controller. * diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.h b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.h index 2d1769bbd24e..ddfc950e90ca 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.h +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_thermal.h @@ -56,6 +56,10 @@ extern int vega20_fan_ctrl_get_fan_speed_rpm(struct pp_hwmgr *hwmgr, uint32_t *speed); extern int vega20_fan_ctrl_set_fan_speed_rpm(struct pp_hwmgr *hwmgr, uint32_t speed); +extern int vega20_fan_ctrl_set_fan_speed_max_rpm(struct pp_hwmgr *hwmgr, + uint32_t speed); +extern int vega20_fan_ctrl_set_fan_speed_min_rpm(struct pp_hwmgr *hwmgr, + uint32_t speed); extern int vega20_fan_ctrl_get_fan_speed_percent(struct pp_hwmgr *hwmgr, uint32_t *speed); extern int vega20_fan_ctrl_set_fan_speed_percent(struct pp_hwmgr *hwmgr, -- 2.19.1 _______________________________________________ amd-gfx mailing list <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <o:p></o:p> <div style="margin-bottom:15.0pt;overflow:auto" id="LPBorder_GT_15403701438120.35346562924862934"> <table class="MsoNormalTable" border="1" cellspacing="0" cellpadding="0" width="90%" style="width:90.0%;background:white;border-top:dotted #C8C8C8 1.0pt;border-left:none;border-bottom:dotted #C8C8C8 1.0pt;border-right:none"> <tbody> <tr> <td valign="top" style="border:none;padding:0cm 0cm 0cm 0cm"> <div id="LPTitle_15403701438100.6054106554689949"> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a><o:p></o:p> </div> <div style="margin-top:7.5pt;margin-bottom:12.0pt" id="LPMetadata_15403701438120.035970050768817985"> lists.freedesktop.org<o:p></o:p> </div> <div id="LPDescription_15403701438120.9681582559548375"> To see the collection of prior postings to the list, visit the amd-gfx Archives.. Using amd-gfx: To post a message to all the list members, send email to <a href="mailto:amd-gfx@lists.freedesktop.org"> amd-gfx@lists.freedesktop.org</a>. You can subscribe to the list, or change your existing subscription, in the sections below.<o:p></o:p> </div> </td> </tr> </tbody> </table> </div> <o:p> </o:p> </div> </div> </div> </div> </div> </div> </body> </html>