<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> Thanks David. I think we can use ring->idx. Best Regards Rex <div style="color: rgb(0, 0, 0);"> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr">From: Zhou, David(ChunMing) Sent: Wednesday, October 24, 2018 2:55 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet <div> </div> </div> <div class="BodyFragment"> <div class="PlainText"> > -----Original Message----- > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Rex > Zhu > Sent: Wednesday, October 24, 2018 2:03 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhu, Rex <Rex.Zhu@amd.com> > Subject: [PATCH v2] drm/amdgpu: Patch csa mc address in IB packet > > the csa buffer is used by sdma engine to do context save when preemption > happens. it the mc address is zero, mean the preemtpion feature(MCBP) is > disabled. > > Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c | 13 +++++++++++++ > drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h | 2 ++ > drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 8 ++++++-- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 8 ++++++-- > 4 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > index 0fb9907..24b80bc 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c > @@ -40,3 +40,16 @@ struct amdgpu_sdma_instance * > amdgpu_get_sdma_instance(struct amdgpu_ring *ring) > > return NULL; > } > + > +int amdgpu_get_sdma_index(struct amdgpu_ring *ring, uint32_t *index) { > + struct amdgpu_device *adev = ring->adev; > + int i; > + > + for (i = 0; i < adev->sdma.num_instances; i++) > + if (ring == &adev->sdma.instance[i].ring || > + ring == &adev->sdma.instance[i].page) > + return i; > + > + return -EINVAL; > +} Loop for checking works, but looks not good. If you need ring index, you can define them first as enum, and evaluate enum index to ring when ring initializing. Regards, David Zhou > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h > b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h > index 479a245..314078a 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.h > @@ -26,6 +26,7 @@ > > /* max number of IP instances */ > #define AMDGPU_MAX_SDMA_INSTANCES 2 > +#define AMDGPU_SDMA_CSA_SIZE (1024) > > enum amdgpu_sdma_irq { > AMDGPU_SDMA_IRQ_TRAP0 = 0, > @@ -96,4 +97,5 @@ struct amdgpu_buffer_funcs { struct > amdgpu_sdma_instance * amdgpu_get_sdma_instance(struct amdgpu_ring > *ring); > > +int amdgpu_get_sdma_index(struct amdgpu_ring *ring, uint32_t *index); > #endif > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > index f5e6aa2..fdc5d75 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c > @@ -424,7 +424,11 @@ static void sdma_v3_0_ring_emit_ib(struct > amdgpu_ring *ring, > bool ctx_switch) > { > unsigned vmid = GET_VMID(job); > + uint64_t csa_mc_addr = job ? job->csa_mc_addr : 0; > + uint32_t i = 0; > > + if (amdgpu_get_sdma_index(ring, &i)) > + return -EINVAL; > /* IB packet must end on a 8 DW boundary */ > sdma_v3_0_ring_insert_nop(ring, (10 - (lower_32_bits(ring->wptr) & > 7)) % 8); > > @@ -434,8 +438,8 @@ static void sdma_v3_0_ring_emit_ib(struct > amdgpu_ring *ring, > amdgpu_ring_write(ring, lower_32_bits(ib->gpu_addr) & 0xffffffe0); > amdgpu_ring_write(ring, upper_32_bits(ib->gpu_addr)); > amdgpu_ring_write(ring, ib->length_dw); > - amdgpu_ring_write(ring, 0); > - amdgpu_ring_write(ring, 0); > + amdgpu_ring_write(ring, lower_32_bits(csa_mc_addr + i * > AMDGPU_SDMA_CSA_SIZE)); > + amdgpu_ring_write(ring, upper_32_bits(csa_mc_addr + i * > +AMDGPU_SDMA_CSA_SIZE)); > > } > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index 2282ac1..e69a584 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -507,7 +507,11 @@ static void sdma_v4_0_ring_emit_ib(struct > amdgpu_ring *ring, > bool ctx_switch) > { > unsigned vmid = GET_VMID(job); > + uint64_t csa_mc_addr = job ? job->csa_mc_addr : 0; > + uint32_t i = 0; > > + if (amdgpu_get_sdma_index(ring, &i)) > + return -EINVAL; > /* IB packet must end on a 8 DW boundary */ > sdma_v4_0_ring_insert_nop(ring, (10 - (lower_32_bits(ring->wptr) & > 7)) % 8); > > @@ -517,8 +521,8 @@ static void sdma_v4_0_ring_emit_ib(struct > amdgpu_ring *ring, > amdgpu_ring_write(ring, lower_32_bits(ib->gpu_addr) & 0xffffffe0); > amdgpu_ring_write(ring, upper_32_bits(ib->gpu_addr)); > amdgpu_ring_write(ring, ib->length_dw); > - amdgpu_ring_write(ring, 0); > - amdgpu_ring_write(ring, 0); > + amdgpu_ring_write(ring, lower_32_bits(csa_mc_addr + i * > AMDGPU_SDMA_CSA_SIZE)); > + amdgpu_ring_write(ring, upper_32_bits(csa_mc_addr + i * > +AMDGPU_SDMA_CSA_SIZE)); > > } > > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk375103" class="OWAAutoLink" previewremoved="true"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> <div id="LPBorder_GT_15403648696980.35762518566836554" style="margin-bottom: 20px; overflow: auto; width: 100%; text-indent: 0px;"> <table id="LPContainer_15403648696960.10036405789195024" style="width: 90%; background-color: rgb(255, 255, 255); position: relative; overflow: auto; padding-top: 20px; padding-bottom: 20px; margin-top: 20px; border-top: 1px dotted rgb(200, 200, 200); border-bottom: 1px dotted rgb(200, 200, 200);" role="presentation" cellspacing="0"> <tbody> <tr style="border-spacing: 0px;" valign="top"> <td id="TextCell_15403648696980.18458402442769917" style="vertical-align: top; position: relative; padding: 0px; display: table-cell;" colspan="2"> <div id="LPRemovePreviewContainer_15403648696980.35276803274853286"></div> <div id="LPTitle_15403648696980.1974260840697557" style="top: 0px; color: rgb(0, 120, 215); font-weight: 400; font-size: 21px; font-family: "wf_segoe-ui_light", "Segoe UI Light", "Segoe WP Light", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; line-height: 21px;"> <a id="LPUrlAnchor_15403648696980.59037122274775" style="text-decoration: none;" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" target="_blank">amd-gfx Info Page - freedesktop.org</a></div> <div id="LPMetadata_15403648696980.43033328175241337" style="margin: 10px 0px 16px; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 14px;"> lists.freedesktop.org</div> <div id="LPDescription_15403648696980.07083429375985362" style="display: block; color: rgb(102, 102, 102); font-weight: 400; font-family: "wf_segoe-ui_normal", "Segoe UI", "Segoe WP", Tahoma, Arial, sans-serif; font-size: 14px; line-height: 20px; max-height: 100px; overflow: hidden;"> To see the collection of prior postings to the list, visit the amd-gfx Archives.. Using amd-gfx: To post a message to all the list members, send email to amd-gfx@lists.freedesktop.org. You can subscribe to the list, or change your existing subscription, in the sections below.</div> </td> </tr> </tbody> </table> </div> </div> </div> </div> </div> </body> </html>