<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Series is:</p>
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Christian König <ckoenig.leichtzumerken@gmail.com><br>
<b>Sent:</b> Tuesday, October 30, 2018 8:17:53 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Subject:</b> [PATCH 4/4] drm/amdgpu: drop the remaining uses of ring idx in messages</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Consistently use the ring name instead.<br>
<br>
Signed-off-by: Christian König <christian.koenig@amd.com><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 6 +++---<br>
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++--<br>
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 5 ++---<br>
3 files changed, 7 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
index 5448cf27654e..ee47c11e92ce 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c<br>
@@ -398,9 +398,9 @@ int amdgpu_fence_driver_start_ring(struct amdgpu_ring *ring,<br>
ring->fence_drv.irq_type = irq_type;<br>
ring->fence_drv.initialized = true;<br>
<br>
- dev_dbg(adev->dev, "fence driver on ring %d use gpu addr 0x%016llx, "<br>
- "cpu addr 0x%p\n", ring->idx,<br>
- ring->fence_drv.gpu_addr, ring->fence_drv.cpu_addr);<br>
+ DRM_DEV_DEBUG(adev->dev, "fence driver on ring %s use gpu addr "<br>
+ "0x%016llx, cpu addr 0x%p\n", ring->name,<br>
+ ring->fence_drv.gpu_addr, ring->fence_drv.cpu_addr);<br>
return 0;<br>
}<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
index fcb370cfa1e7..100f23b5e22f 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c<br>
@@ -1620,8 +1620,8 @@ static int gfx_v9_0_ngg_en(struct amdgpu_device *adev)<br>
/* Clear GDS reserved memory */<br>
r = amdgpu_ring_alloc(ring, 17);<br>
if (r) {<br>
- DRM_ERROR("amdgpu: NGG failed to lock ring %d (%d).\n",<br>
- ring->idx, r);<br>
+ DRM_ERROR("amdgpu: NGG failed to lock ring %s (%d).\n",<br>
+ ring->name, r);<br>
return r;<br>
}<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c<br>
index a7e61c6de71c..6cedf7ebf036 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c<br>
@@ -739,9 +739,8 @@ static int gmc_v9_0_late_init(void *handle)<br>
unsigned vmhub = ring->funcs->vmhub;<br>
<br>
ring->vm_inv_eng = vm_inv_eng[vmhub]++;<br>
- dev_info(adev->dev, "ring %u(%s) uses VM inv eng %u on hub %u\n",<br>
- ring->idx, ring->name, ring->vm_inv_eng,<br>
- ring->funcs->vmhub);<br>
+ dev_info(adev->dev, "ring %s uses VM inv eng %u on hub %u\n",<br>
+ ring->name, ring->vm_inv_eng, ring->funcs->vmhub);<br>
}<br>
<br>
/* Engine 16 is used for KFD and 17 for GART flushes */<br>
-- <br>
2.14.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>