<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Alex Deucher <alexander.deucher@amd.com><br>
</p>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Jim Qu <Jim.Qu@amd.com><br>
<b>Sent:</b> Wednesday, November 7, 2018 5:42:12 AM<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> Qu, Jim<br>
<b>Subject:</b> [PATCH] drm/amd/powerplay: correct code style</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Change-Id: I844949ae1738adae3dfad431a270913d04832f56<br>
Signed-off-by: Jim Qu <Jim.Qu@amd.com><br>
---<br>
.../drm/amd/powerplay/hwmgr/vega20_hwmgr.c | 135 ++++++------------<br>
1 file changed, 45 insertions(+), 90 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c<br>
index cb3c3d69c3d3..f2daf00cc911 100644<br>
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c<br>
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega20_hwmgr.c<br>
@@ -3454,109 +3454,64 @@ static int vega20_get_thermal_temperature_range(struct pp_hwmgr *hwmgr,<br>
<br>
static const struct pp_hwmgr_func vega20_hwmgr_funcs = {<br>
/* init/fini related */<br>
- .backend_init =<br>
- vega20_hwmgr_backend_init,<br>
- .backend_fini =<br>
- vega20_hwmgr_backend_fini,<br>
- .asic_setup =<br>
- vega20_setup_asic_task,<br>
- .power_off_asic =<br>
- vega20_power_off_asic,<br>
- .dynamic_state_management_enable =<br>
- vega20_enable_dpm_tasks,<br>
- .dynamic_state_management_disable =<br>
- vega20_disable_dpm_tasks,<br>
+ .backend_init = vega20_hwmgr_backend_init,<br>
+ .backend_fini = vega20_hwmgr_backend_fini,<br>
+ .asic_setup = vega20_setup_asic_task,<br>
+ .power_off_asic = vega20_power_off_asic,<br>
+ .dynamic_state_management_enable = vega20_enable_dpm_tasks,<br>
+ .dynamic_state_management_disable = vega20_disable_dpm_tasks,<br>
/* power state related */<br>
- .apply_clocks_adjust_rules =<br>
- vega20_apply_clocks_adjust_rules,<br>
- .pre_display_config_changed =<br>
- vega20_pre_display_configuration_changed_task,<br>
- .display_config_changed =<br>
- vega20_display_configuration_changed_task,<br>
+ .apply_clocks_adjust_rules = vega20_apply_clocks_adjust_rules,<br>
+ .pre_display_config_changed = vega20_pre_display_configuration_changed_task,<br>
+ .display_config_changed = vega20_display_configuration_changed_task,<br>
.check_smc_update_required_for_display_configuration =<br>
vega20_check_smc_update_required_for_display_configuration,<br>
.notify_smc_display_config_after_ps_adjustment =<br>
vega20_notify_smc_display_config_after_ps_adjustment,<br>
/* export to DAL */<br>
- .get_sclk =<br>
- vega20_dpm_get_sclk,<br>
- .get_mclk =<br>
- vega20_dpm_get_mclk,<br>
- .get_dal_power_level =<br>
- vega20_get_dal_power_level,<br>
- .get_clock_by_type_with_latency =<br>
- vega20_get_clock_by_type_with_latency,<br>
- .get_clock_by_type_with_voltage =<br>
- vega20_get_clock_by_type_with_voltage,<br>
- .set_watermarks_for_clocks_ranges =<br>
- vega20_set_watermarks_for_clocks_ranges,<br>
- .display_clock_voltage_request =<br>
- vega20_display_clock_voltage_request,<br>
- .get_performance_level =<br>
- vega20_get_performance_level,<br>
+ .get_sclk = vega20_dpm_get_sclk,<br>
+ .get_mclk = vega20_dpm_get_mclk,<br>
+ .get_dal_power_level = vega20_get_dal_power_level,<br>
+ .get_clock_by_type_with_latency = vega20_get_clock_by_type_with_latency,<br>
+ .get_clock_by_type_with_voltage = vega20_get_clock_by_type_with_voltage,<br>
+ .set_watermarks_for_clocks_ranges = vega20_set_watermarks_for_clocks_ranges,<br>
+ .display_clock_voltage_request = vega20_display_clock_voltage_request,<br>
+ .get_performance_level = vega20_get_performance_level,<br>
/* UMD pstate, profile related */<br>
- .force_dpm_level =<br>
- vega20_dpm_force_dpm_level,<br>
- .get_power_profile_mode =<br>
- vega20_get_power_profile_mode,<br>
- .set_power_profile_mode =<br>
- vega20_set_power_profile_mode,<br>
+ .force_dpm_level = vega20_dpm_force_dpm_level,<br>
+ .get_power_profile_mode = vega20_get_power_profile_mode,<br>
+ .set_power_profile_mode = vega20_set_power_profile_mode,<br>
/* od related */<br>
- .set_power_limit =<br>
- vega20_set_power_limit,<br>
- .get_sclk_od =<br>
- vega20_get_sclk_od,<br>
- .set_sclk_od =<br>
- vega20_set_sclk_od,<br>
- .get_mclk_od =<br>
- vega20_get_mclk_od,<br>
- .set_mclk_od =<br>
- vega20_set_mclk_od,<br>
- .odn_edit_dpm_table =<br>
- vega20_odn_edit_dpm_table,<br>
+ .set_power_limit = vega20_set_power_limit,<br>
+ .get_sclk_od = vega20_get_sclk_od,<br>
+ .set_sclk_od = vega20_set_sclk_od,<br>
+ .get_mclk_od = vega20_get_mclk_od,<br>
+ .set_mclk_od = vega20_set_mclk_od,<br>
+ .odn_edit_dpm_table = vega20_odn_edit_dpm_table,<br>
/* for sysfs to retrive/set gfxclk/memclk */<br>
- .force_clock_level =<br>
- vega20_force_clock_level,<br>
- .print_clock_levels =<br>
- vega20_print_clock_levels,<br>
- .read_sensor =<br>
- vega20_read_sensor,<br>
+ .force_clock_level = vega20_force_clock_level,<br>
+ .print_clock_levels = vega20_print_clock_levels,<br>
+ .read_sensor = vega20_read_sensor,<br>
/* powergate related */<br>
- .powergate_uvd =<br>
- vega20_power_gate_uvd,<br>
- .powergate_vce =<br>
- vega20_power_gate_vce,<br>
+ .powergate_uvd = vega20_power_gate_uvd,<br>
+ .powergate_vce = vega20_power_gate_vce,<br>
/* thermal related */<br>
- .start_thermal_controller =<br>
- vega20_start_thermal_controller,<br>
- .stop_thermal_controller =<br>
- vega20_thermal_stop_thermal_controller,<br>
- .get_thermal_temperature_range =<br>
- vega20_get_thermal_temperature_range,<br>
- .register_irq_handlers =<br>
- smu9_register_irq_handlers,<br>
- .disable_smc_firmware_ctf =<br>
- vega20_thermal_disable_alert,<br>
+ .start_thermal_controller = vega20_start_thermal_controller,<br>
+ .stop_thermal_controller = vega20_thermal_stop_thermal_controller,<br>
+ .get_thermal_temperature_range = vega20_get_thermal_temperature_range,<br>
+ .register_irq_handlers = smu9_register_irq_handlers,<br>
+ .disable_smc_firmware_ctf = vega20_thermal_disable_alert,<br>
/* fan control related */<br>
- .get_fan_speed_percent =<br>
- vega20_fan_ctrl_get_fan_speed_percent,<br>
- .set_fan_speed_percent =<br>
- vega20_fan_ctrl_set_fan_speed_percent,<br>
- .get_fan_speed_info =<br>
- vega20_fan_ctrl_get_fan_speed_info,<br>
- .get_fan_speed_rpm =<br>
- vega20_fan_ctrl_get_fan_speed_rpm,<br>
- .set_fan_speed_rpm =<br>
- vega20_fan_ctrl_set_fan_speed_rpm,<br>
- .get_fan_control_mode =<br>
- vega20_get_fan_control_mode,<br>
- .set_fan_control_mode =<br>
- vega20_set_fan_control_mode,<br>
+ .get_fan_speed_percent = vega20_fan_ctrl_get_fan_speed_percent,<br>
+ .set_fan_speed_percent = vega20_fan_ctrl_set_fan_speed_percent,<br>
+ .get_fan_speed_info = vega20_fan_ctrl_get_fan_speed_info,<br>
+ .get_fan_speed_rpm = vega20_fan_ctrl_get_fan_speed_rpm,<br>
+ .set_fan_speed_rpm = vega20_fan_ctrl_set_fan_speed_rpm,<br>
+ .get_fan_control_mode = vega20_get_fan_control_mode,<br>
+ .set_fan_control_mode = vega20_set_fan_control_mode,<br>
/* smu memory related */<br>
- .notify_cac_buffer_info =<br>
- vega20_notify_cac_buffer_info,<br>
- .enable_mgpu_fan_boost =<br>
- vega20_enable_mgpu_fan_boost,<br>
+ .notify_cac_buffer_info = vega20_notify_cac_buffer_info,<br>
+ .enable_mgpu_fan_boost = vega20_enable_mgpu_fan_boost,<br>
};<br>
<br>
int vega20_hwmgr_init(struct pp_hwmgr *hwmgr)<br>
-- <br>
2.17.1<br>
<br>
_______________________________________________<br>
amd-gfx mailing list<br>
amd-gfx@lists.freedesktop.org<br>
<a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br>
</div>
</span></font></div>
</body>
</html>